Merged
Conversation
Gets nativeCurrency from state and uses in place of the previously hardcoded ETH value in the confirm approve component.
Sync `master` with `develop`
These props were never given. They have been removed to simplify the component.
Fixes #6071 The origin of the dapp that suggested signing has been added to the signature request confirmation page. This only applies to `eth_sign`, `personal_sign`, `eth_signTypedData`, and `eth_signTypedData_v1`. The confirmation page for `eth_signTypedData_v3` and `eth_signTypedData_v4` already featured the origin.
Fixes #5611 The origin that suggests a transaction is now shown on the transaction confirmation page. If the transaction was initiated from within MetaMask (e.g. via the 'Send' flow or swaps), no origin is shown. This was based upon designs that were linked in the PR #9377. This is a temporary measure until our newer transaction confirmation designs can be implemented.
Bumps [electron](https://github.com/electron/electron) from 9.1.2 to 9.4.2. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.1.2...v9.4.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The Chip component was emitting a PropType error because it was missing the `labelProps.children` prop. It was never supposed to be given that prop - it was a mistake in the PropType declaration. The PropTypes have been fixed to prevent this warning.
The `menu-droppo` external click handler would fail to update when the prop changed while the menu wasn't shown. This bug isn't exposed anywhere yet as far as I know, but I ran into it when working on a different bug fix.
This fixes a bug where the network menu would remain present after a second click on the network menu button. The bug was caused by the click being handled _twice_, by two separate handlers. First it was caught by the external click handler of the dropdown menu, which closed the menu. Second, it was caught by the network button itself, which re- opened the menu. This all happens quickly enough that to the user it appears to stay open. The external click handler of the menu now only fires if the menu is open. Additionally, any click that is caught by the network menu is stopped from propagating further, so that it can't trigger additional click handlers.
Upon the first render, the "original" signature request confirmation page would trigger a PropType error. This was caused by unexpected mutation of the state props. The container has been updated to avoid mutating the props, and now the PropType warning is no longer present.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Fixes #10111 Determine if the msgParams/address for the newRequestEncryptionPublicKey is a ledger keyring via getKeyringForAccount and return a promise rejection.
* use @lavamoat/allow-scripts for package postinstall allow list * dnode: set "weak" to false Co-authored-by: kumavis <kumavis@users.noreply.github.com> Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Move from using the backgound/metamask-controller instance to a stubbed/mocked out verison of the background methods.
* Update `ko` localized messages These translations were provided by Lionbridge. * Update `lockoutTimeTooGreat` message * Update statements with bold 'Never' The sentences did not make sense previously. They have been updated to be grammatically correct and to emphasize the negation. * Apply suggested change to 'swapNewQuoteIn'
Further implements request rejection on eth_getEncryptionPublicKey for Trezor as they do not implement this method either.
* add MetaMask Template Renderer * add areEqual fn and change acc var name * use key
* Use nock in to intercept gas call for gas-duck test Use nock instead of stubbing out the window fetch. My suspicion is that when the test runs the window sometimes wouldn't be intialized/referenced, which could explain the intermittent test failures in those particular tests that call window.fetch. Using nock allows the call to be intercepted more reliably.
* manual rebase against develop * Update .nvmrc
The `verify-locale-strings.js` script now validates that the descriptions from the `en` locale are also present in all other locales. These descriptions are intended to help with translation, and are not meant to be translated. This check will ensure that translators don't accidentally translate these. It also ensures they're present alongside each translated message, which might be helpful for understanding context.
* add yarn rc file to disable scripts * remove ignore scripts in CI * re-add entry * add lavamoat preinstall always fail * allow-scripts - add missing package to denylist Co-authored-by: kumavis <kumavis@users.noreply.github.com>
* ci - run storybook and add to build-artifacts * ci/storybook - rename storybook build path and fix artifact upload * ci/storybook - rename link text * clean - remove accidently committed storybook build dir * storybook - fix image path to relative (#10364)
* @metamask/eslint-config@5.0.0 * Update eslintrc and prettierrc * yarn lint:fix
Follows on from the work done to upgrade Node to version 14 #9514
* deps - run "yarn setup" to install deps * doc - add "yarn setup" to local dev instructions
* Update standard swaps build quote screen token verification message * Add actionable warning token verification message to swaps build quote screen * Simplify swapTokenVerification translations * Use original verifyThisTokenOn message instead of swapsConfirmTokenAddressOnEtherscan * Restore verifyThisTokenOn message to hi locale * Support type and the withRightButton option as parameters on the actionable message component * Use 'continue' in place of swapPriceDifferenceAcknowledgementNoFiat message * Use wrapperClassName property on infotooltip in actionable-message * Remove unnecessary change * Lint fix
* Make action elements in actionable message component accessible by making them buttons * Remove unnecessary cursor pointer
* storybook - i18n toolbar * lint fix
Fixes #10356 There was a bug in the inpage provider that would mistakenly report usage of our injected `web3` instance when the `web3.currentProvider` property was accessed. This was fixed in v8.0.4 of `@metamask/inpage-provider`.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Author
Builds ready [e66709e]
Page Load Metrics (1369 ± 64 ms)
|
Collaborator
Author
Builds ready [9489dbe]
Page Load Metrics (530 ± 20 ms)
|
tmashuang
approved these changes
Feb 9, 2021
Contributor
tmashuang
left a comment
There was a problem hiding this comment.
I wasnt able to reproduce #10347 live, production, but recreating the conditions for it in the component indeed disables interaction of the entire quote view, and the warning acknowledge button needs to be clicked to continue on with the swap.
Some commits were add by myself (#10326, #10330, #10298). If anyone else wants to reaffirm those changes, it would be much appreciated, otherwise this LGTM.
danjm
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀