Merged
Conversation
Collaborator
Builds ready [3127e33]
Page Load Metrics (861 ± 50 ms)
|
39c2e8f to
64d06d6
Compare
3127e33 to
8697a0e
Compare
Collaborator
Builds ready [8697a0e]
Page Load Metrics (845 ± 153 ms)
|
Collaborator
Builds ready [ea97da2]
Page Load Metrics (587 ± 28 ms)
|
Gudahtt
reviewed
Jan 28, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good! I appreciate the commitment to using proper HTML tags. Just one minor comment.
Collaborator
Builds ready [25500b3]
Page Load Metrics (856 ± 21 ms)
|
Gudahtt
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
#10289Rationale
Using a
<dl>for terms and definitions is good, semantic markup. We have a new component introduced in theadd-ethereum-chainUI that has terms in bold and definitions or values in normal text below the bolded term. This component allows passing a simple dictionary object and gets a formatted<dl>out of it. Also allows for passing tooltips as an object for the use case where the "terms" are the "keys" and the "definitions" are "values". Examples of each belowTerm with Definition
Key with Value
You can also control the typography for the two different types (definition, term)
Typography controls
You can also expand the space between entries via
gapSizepropgapSize control
Additional notes
This also cleans up some prop-type warnings from my previous work :(