Skip to content

Add .yarnrc to disable scripts#10354

Merged
Gudahtt merged 5 commits intodevelopfrom
yarnrc-disable-scripts
Feb 4, 2021
Merged

Add .yarnrc to disable scripts#10354
Gudahtt merged 5 commits intodevelopfrom
yarnrc-disable-scripts

Conversation

@EtDu
Copy link
Copy Markdown
Contributor

@EtDu EtDu commented Feb 3, 2021

  • Adds .yarnrc file to disable install scripts
  • Removes --ignore-scripts flag from prep-deps in CI

@EtDu EtDu requested review from a team and kumavis as code owners February 3, 2021 07:09
@EtDu EtDu requested a review from NiranjanaBinoy February 3, 2021 07:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kumavis
Copy link
Copy Markdown
Member

kumavis commented Feb 3, 2021

this .yarnrc ensures that scripts are not run when you run yarn or yarn install

in development, this means you will need to run yarn allow-scripts to trigger the correct build scripts

kumavis
kumavis previously approved these changes Feb 3, 2021
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [67b05e4]
Page Load Metrics (800 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5311178147
domContentLoaded51395679711455
load51595780011354
domInteractive51395579711455

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [000de97]
Page Load Metrics (559 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4410856157
domContentLoaded33075755810349
load33175855910349
domInteractive33075755710349

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit fc409a1 into develop Feb 4, 2021
@Gudahtt Gudahtt deleted the yarnrc-disable-scripts branch February 4, 2021 01:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants