Skip to content

Make action elements in actionable message component accessible#10386

Merged
danjm merged 2 commits intodevelopfrom
actionable-message-button-accessible
Feb 5, 2021
Merged

Make action elements in actionable message component accessible#10386
danjm merged 2 commits intodevelopfrom
actionable-message-button-accessible

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Feb 5, 2021

The actionable message components has links / buttons that are currently inaccessible as they are just divs. This updates that, allowing the user to tab to the element.

@danjm danjm requested a review from a team as a code owner February 5, 2021 17:39
@danjm danjm requested a review from Gudahtt February 5, 2021 17:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.


.actionable-message__action {
font-weight: normal;
cursor: pointer;
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other cursor: pointer (also on actionable-message__action, declared earlier on line 30) is now unnecessary as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, removed in 3a38844

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e8904a3]
Page Load Metrics (738 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5611171126
domContentLoaded3928657379546
load3938667389546
domInteractive3928647379546

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3a38844]
Page Load Metrics (660 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint469862147
domContentLoaded528103365813465
load529103566013565
domInteractive528103365813465

@danjm danjm merged commit 27d6c6e into develop Feb 5, 2021
@danjm danjm deleted the actionable-message-button-accessible branch February 5, 2021 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants