Merged
Conversation
690dedc to
a6b6014
Compare
Collaborator
Builds ready [a6b6014]
Page Load Metrics (905 ± 73 ms)
|
a6b6014 to
85e1c5d
Compare
Collaborator
Builds ready [85e1c5d]
Page Load Metrics (572 ± 46 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The new
add-ethereum-chainrequest UI designs have a redesigned alert component for gaining the user's attention. I've dubbed this component the 'Callout' because it could stand its own as just information with significance. Passing a 'dismiss' function to theCalloutrenders a dismissibleCalloutthat acts as a sort of an alert. A close button is rendered (x), and clicking that button animates theCalloutopacity. It's up to the parent component to not render a dismissedCallout.Examples
Non dismissible callout
Single dismissible callout
Multiple dismissible callouts
Animation