Skip to content

@metamask/eslint config@5.0.0#10358

Merged
rekmarks merged 5 commits intodevelopfrom
@metamask/eslint-config@5.0.0
Feb 4, 2021
Merged

@metamask/eslint config@5.0.0#10358
rekmarks merged 5 commits intodevelopfrom
@metamask/eslint-config@5.0.0

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Feb 3, 2021

It's semicolons o'clock. Recommend reviewing individual commits:

@rekmarks rekmarks requested a review from brad-decker February 3, 2021 20:46
@rekmarks rekmarks requested review from a team and kumavis as code owners February 3, 2021 20:46
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d5ad26e]
Page Load Metrics (581 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48796084
domContentLoaded3677405798039
load3687415818038
domInteractive3677405798039

@kumavis
Copy link
Copy Markdown
Member

kumavis commented Feb 4, 2021

why tho
i dissent

@rekmarks
Copy link
Copy Markdown
Member Author

rekmarks commented Feb 4, 2021

@kumavis most of the discussion for why is on Slack, I believe. A plurality of North America TZ extension devs were positive, some neutral, and I think no one outright against it.

@rekmarks rekmarks merged commit 76a2a9b into develop Feb 4, 2021
@rekmarks rekmarks deleted the @metamask/eslint-config@5.0.0 branch February 4, 2021 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d5717e1]
Page Load Metrics (662 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4911876168
domContentLoaded35499566119091
load35599666219091
domInteractive35499466019091

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants