Skip to content

Use nativeCurrency in the confirm approve screen#10298

Merged
tmashuang merged 1 commit intodevelopfrom
use-nativeCurrency-confirmApprove
Jan 28, 2021
Merged

Use nativeCurrency in the confirm approve screen#10298
tmashuang merged 1 commit intodevelopfrom
use-nativeCurrency-confirmApprove

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

Gets nativeCurrency from state and uses in place of the previously hardcoded ETH value in the confirm approve component.

After

Gets nativeCurrency from state and uses in place of the previously hardcoded ETH value in the confirm approve component.
@tmashuang tmashuang requested a review from a team as a code owner January 27, 2021 20:12
@tmashuang tmashuang requested a review from danjm January 27, 2021 20:12
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [756cd99]
Page Load Metrics (650 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4512162178
domContentLoaded4827906497737
load4847906507737
domInteractive4827896497737

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit 425ec62 into develop Jan 28, 2021
@tmashuang tmashuang deleted the use-nativeCurrency-confirmApprove branch January 28, 2021 06:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants