Skip to content

storybook - i18n toolbar#10381

Merged
kumavis merged 2 commits intodevelopfrom
storybook-i18n
Feb 6, 2021
Merged

storybook - i18n toolbar#10381
kumavis merged 2 commits intodevelopfrom
storybook-i18n

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Feb 5, 2021

made a toolbar dropdown for selecting a language in storybook i18n

@kumavis kumavis requested a review from a team as a code owner February 5, 2021 06:57
@kumavis kumavis requested a review from brad-decker February 5, 2021 06:57
@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Feb 5, 2021

wait is addParameters the same as this toolbar thing?

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [fa9f307]
Page Load Metrics (890 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6311585136
domContentLoaded64110498899144
load64310518909144
domInteractive64110498889144

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,58 @@
import * as am from '../app/_locales/am/messages.json';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that you can't export * as ___ from ... yet. Soon hopefully!

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Feb 6, 2021

btw this required a retry of e2e-firefox and benchmark

@kumavis kumavis merged commit b021573 into develop Feb 6, 2021
@kumavis kumavis deleted the storybook-i18n branch February 6, 2021 02:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants