Skip to content

Ci storybook rel img#10364

Merged
kumavis merged 1 commit intoci-storybookfrom
ci-storybook-rel-img
Feb 4, 2021
Merged

Ci storybook rel img#10364
kumavis merged 1 commit intoci-storybookfrom
ci-storybook-rel-img

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Feb 4, 2021

fixes an issue with an image not resolving when storybook is hosted via ci build artifacts
intended to be merged after #10360

@kumavis kumavis requested a review from a team as a code owner February 4, 2021 03:29
@kumavis kumavis requested a review from danjm February 4, 2021 03:29
@kumavis kumavis changed the base branch from develop to ci-storybook February 4, 2021 03:30
@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Feb 4, 2021

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally as well, and the relative path works fine.

@kumavis kumavis merged commit df54e84 into ci-storybook Feb 4, 2021
@kumavis kumavis deleted the ci-storybook-rel-img branch February 4, 2021 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants