Skip to content

ci - run storybook and add to build-artifacts#10360

Merged
kumavis merged 5 commits intodevelopfrom
ci-storybook
Feb 4, 2021
Merged

ci - run storybook and add to build-artifacts#10360
kumavis merged 5 commits intodevelopfrom
ci-storybook

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Feb 4, 2021

get story book links on every successful build 😁

@kumavis kumavis requested a review from a team as a code owner February 4, 2021 02:14
@kumavis kumavis requested a review from darkwing February 4, 2021 02:14
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1541919]
Page Load Metrics (1207 ± 209 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded55324951204434209
load55424971207434209
domInteractive55324951204434209

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4d36228]
Page Load Metrics (927 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded529132692419694
load530133092719895
domInteractive528132592319694

@kumavis kumavis mentioned this pull request Feb 4, 2021
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've accidentally committed the contents of the .out directory

Gudahtt
Gudahtt previously approved these changes Feb 4, 2021
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [df54e84]
Page Load Metrics (624 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50806084
domContentLoaded4187326227737
load4197346247737
domInteractive4187316227637

@kumavis kumavis merged commit efd2801 into develop Feb 4, 2021
@kumavis kumavis deleted the ci-storybook branch February 4, 2021 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
@brad-decker
Copy link
Copy Markdown
Contributor

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants