Add origin to transaction confirmation#10296
Merged
Conversation
f59edc1 to
0e0aae0
Compare
Member
Author
|
This depends upon #10295 |
106e514 to
eef7dd8
Compare
0e0aae0 to
a39693b
Compare
Collaborator
Builds ready [a39693b]
Page Load Metrics (785 ± 71 ms)
|
Base automatically changed from
remove-unused-transaction-base-props
to
develop
January 28, 2021 17:17
Fixes #5611 The origin that suggests a transaction is now shown on the transaction confirmation page. If the transaction was initiated from within MetaMask (e.g. via the 'Send' flow or swaps), no origin is shown. This was based upon designs that were linked in the PR #9377. This is a temporary measure until our newer transaction confirmation designs can be implemented.
a39693b to
7baa574
Compare
Collaborator
Builds ready [7baa574]
Page Load Metrics (579 ± 12 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5611
The origin that suggests a transaction is now shown on the transaction confirmation page. If the transaction was initiated from within MetaMask (e.g. via the 'Send' flow or swaps), no origin is shown.
This was based upon designs that were linked in the PR #9377. This is a temporary measure until our newer transaction confirmation designs can be implemented.
Manual testing steps:
Initiate a transaction from any dapp (ETH send, token transfer, or any other contract interaction)
See that the origin is shown
Initiate a transaction from the Send flow
See that the origin is not shown
Screenshot: