Add time and origin to confirm page#9377
Add time and origin to confirm page#9377PatrykLucka wants to merge 3 commits intoMetaMask:developfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e3f9d51 to
90965b2
Compare
|
@rachelcope @jacobcantele Is this a feature we want? Any design feedback? |
|
Ok we're going to make some design proposal improvements, keeping this open for Rachel to add those designs. |
|
I've updated the designs to more closely align with our other confirmations and design system.
Figma file: |
Gudahtt
left a comment
There was a problem hiding this comment.
The new designs posted in @rachelcope 's last comment are ready to implement now. The changes to the confirmation page are to remove the timestamp and left-align the origin. The signature request has a few more substantial changes, making it look a bit more like the connect confirmation.
Let us know if you have any questions! Or if you need to hand this off.
|
Fixes #6071 |
|
Let's just add the origin for now. |
|
This has been superseded by #10300 and #10296, which add the origin to the signature request confirmation page and transaction confirmation page respectively. The time will added in a future redesign. Thanks again @PatrykLucka for your work on this! |
This PR adds information about time of transaction initiation, origin and favicon to
transaction confirmation screen
signing screen
I'm not sure about the design - although in my opinion at least signing screen looks pretty nice : )
Also let me know if I missed any other screens!
Fixes #6071
Related to #5611 #6433