Add origin to signature request confirmation page#10300
Merged
Conversation
Fixes #6071 The origin of the dapp that suggested signing has been added to the signature request confirmation page. This only applies to `eth_sign`, `personal_sign`, `eth_signTypedData`, and `eth_signTypedData_v1`. The confirmation page for `eth_signTypedData_v3` and `eth_signTypedData_v4` already featured the origin.
Collaborator
Builds ready [fe7861d]
Page Load Metrics (561 ± 26 ms)
|
rachelcope
previously approved these changes
Jan 28, 2021
rachelcope
left a comment
There was a problem hiding this comment.
Looks good for now as a quick fix
|
I'll be pushing for design refresh for this page soon 😸 |
danjm
reviewed
Jan 28, 2021
| <div className="request-signature__headline"> | ||
| {this.context.t('yourSigRequested')} | ||
| <div className="request-signature__origin-row"> | ||
| <div className="request-signature__origin-label">Origin:</div> |
Contributor
There was a problem hiding this comment.
Should "Origin:" be translated?
Member
Author
There was a problem hiding this comment.
Of course 🤦 Yes it should, good catch!
danjm
suggested changes
Jan 28, 2021
Contributor
danjm
left a comment
There was a problem hiding this comment.
Left one comment, otherwise code looks good
danjm
approved these changes
Jan 28, 2021
Contributor
danjm
left a comment
There was a problem hiding this comment.
e2e fail seems to be unrelated. LGTM. Approved.
Collaborator
Builds ready [a774097]
Page Load Metrics (513 ± 41 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6071
The origin of the dapp that suggested signing has been added to the signature request confirmation page. This only applies to
eth_sign,personal_sign,eth_signTypedData, andeth_signTypedData_v1. The confirmation page foreth_signTypedData_v3andeth_signTypedData_v4already featured the origin.Screenshots
eth_sign:eth_signTypedData: