Require English descriptions in locale files#10260
Merged
Conversation
Base automatically changed from
remove-missing-messages-from-verify-locales-script
to
develop
January 26, 2021 17:33
e0580a3 to
b441b7c
Compare
Collaborator
Builds ready [84086dd]
Page Load Metrics (617 ± 41 ms)
|
Collaborator
Builds ready [b441b7c]
Page Load Metrics (799 ± 63 ms)
|
The `verify-locale-strings.js` script now validates that the descriptions from the `en` locale are also present in all other locales. These descriptions are intended to help with translation, and are not meant to be translated. This check will ensure that translators don't accidentally translate these. It also ensures they're present alongside each translated message, which might be helpful for understanding context.
84086dd to
67cd5ed
Compare
Collaborator
Builds ready [67cd5ed]
Page Load Metrics (570 ± 34 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verify-locale-strings.jsscript now validates that the descriptions from theenlocale are also present in all other locales.These descriptions are intended to help with translation, and are not meant to be translated. This check will ensure that translators don't accidentally translate these. It also ensures they're present alongside each translated message, which might be helpful for understanding context.