add inverted info icon, and update props#10305
Merged
brad-decker merged 2 commits intodevelopfrom Feb 1, 2021
Merged
Conversation
Collaborator
Builds ready [03e88a9]
Page Load Metrics (581 ± 13 ms)
|
brad-decker
commented
Feb 1, 2021
| } | ||
|
|
||
| InfoIconInverted.propTypes = { | ||
| severity: PropTypes.oneOf(Object.keys(SEVERITIES)), |
Contributor
Author
There was a problem hiding this comment.
this is wrong, should be Object.values. I'm gonna fixup and then repush
Contributor
Author
|
additional changes isolated in new commit, involved fix for prop types, a couple additional usage updates to use the constants, and adding InfoIcon and InfoIconInverted to the storybook stories. |
Collaborator
Builds ready [b157976]
Page Load Metrics (915 ± 40 ms)
|
rekmarks
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We have two versions of the info icon, one where the border/icon has color applied and one where the info icon is white, and the background has color applied. This pull request adds the inverted version and adds some constants to handle the different options for choosing which color to apply from the design system. Also updates the icon scss to use the proper variables from the design-system. One minor unrelated change is updating the color of the icon-outline.