Use allow-scripts by EtDu · Pull Request #10009 · MetaMask/metamask-extension

EtDu · 2020-12-07T05:45:27Z

Use dependency allow-scripts instead of manually running install/postinstall scripts of certain deps

github-actions · 2020-12-07T05:45:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

package.json

kumavis · 2020-12-08T07:45:04Z

brought in the weak-disabling commit here, because weak relies on binding@1 do some magic, maybe walking all the deps to find places where binding is configured. thats dangerous and unnecesary so we shouldnt do it.
since the built weak is only present in nodejs (not browser) this does not affect the built extension

metamaskbot · 2020-12-08T08:07:45Z

Builds ready [6e1faed]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
dep viz: background
all artifacts

Page Load Metrics (368 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	29	73	48	16	8
		domContentLoaded	247	577	366	98	47
		load	248	579	368	98	47
		domInteractive	247	577	366	98	47

kumavis

looks good 👍

metamaskbot · 2020-12-08T08:26:35Z

Builds ready [6e1faed]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
dep viz: background
all artifacts

Page Load Metrics (436 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	84	53	14	7
		domContentLoaded	281	697	434	126	61
		load	282	699	436	126	61
		domInteractive	281	696	434	126	61

package.json

kumavis · 2020-12-10T01:42:15Z

pending a security review of allow-scripts

metamaskbot · 2020-12-10T02:32:57Z

Builds ready [4b29579]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
dep viz: background
all artifacts

Page Load Metrics (396 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	30	104	53	20	10
		domContentLoaded	253	551	394	95	46
		load	254	552	396	95	46
		domInteractive	253	550	394	95	46

metamaskbot · 2021-01-16T12:53:55Z

Builds ready [1a1a112]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
code coverage: Report
dep viz: background
all artifacts

Page Load Metrics (495 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	54	44	8	4
		domContentLoaded	311	564	494	86	41
		load	313	565	495	86	41
		domInteractive	311	563	494	86	41

kumavis · 2021-01-16T13:37:15Z

allow-scripts did not pass the security review, so now lavamoat has its own
this is good to go

rekmarks · 2021-01-16T17:47:48Z

Does @lavamoat/allow-scripts have a repo?

kumavis · 2021-01-18T02:53:06Z

@rekmarks whoops, hadn't pressed merge on the lavamoat PR yet! merged now
https://github.com/LavaMoat/LavaMoat/tree/main/packages/allow-scripts

into allow-scripts

…extension into allow-scripts

kumavis · 2021-02-02T03:07:03Z

this is ready to merge
this should have no impact on current workflows
this should be fairly stable, only requiring a change when a dep that requires an npm pre/post-install hook is added

metamaskbot · 2021-02-02T03:12:37Z

Builds ready [08c5b83]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
code coverage: Report
dep viz: background
all artifacts

Page Load Metrics (828 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	98	80	10	5
		domContentLoaded	521	973	826	111	53
		load	522	975	828	111	53
		domInteractive	520	972	826	111	53

package.json

.circleci/scripts/deps-install.sh

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

rekmarks

LGTM!

rekmarks

We are investigating something.

rekmarks

We concluded investigating a thing.

EtDu · 2021-02-02T03:54:00Z

green lights

metamaskbot · 2021-02-02T03:55:43Z

Builds ready [14c3154]

builds: chrome, firefox, opera
bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
code coverage: Report
dep viz: background
all artifacts

Page Load Metrics (562 ± 19 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	44	72	55	8	4
		domContentLoaded	434	633	561	41	20
		load	435	634	562	41	19
		domInteractive	434	633	561	41	20

EtDu added 3 commits December 7, 2020 12:38

use allow-scripts

bf0c731

config for allow scripts

d073dce

use allow scripts in CI

f692f89

EtDu requested review from a team and kumavis as code owners December 7, 2020 05:45

EtDu requested a review from darkwing December 7, 2020 05:45

EtDu added 3 commits December 7, 2020 13:46

fix package json lint

90ac815

fix configuration

b191cb4

set weak to false

5fac7ec

kumavis reviewed Dec 8, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

kumavis and others added 2 commits December 8, 2020 15:07

fix: disable dnode weak on nodejs for node@10 support

d45e6c2

switch position of weak

ff27cce

fix lint

6e1faed

kumavis previously approved these changes Dec 8, 2020

View reviewed changes

rekmarks reviewed Dec 9, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

kumavis added the DO-NOT-MERGE Pull requests that should not be merged label Dec 10, 2020

use specific package versions for allow list

4b29579

EtDu dismissed kumavis’s stale review via 4b29579 December 10, 2020 02:16

brad-decker assigned kumavis and rekmarks Dec 10, 2020

rekmarks marked this pull request as draft December 14, 2020 17:06

EtDu added 3 commits January 16, 2021 13:28

use allow-scripts

b044e11

config for allow scripts

f616fce

use allow scripts in CI

7ac7b83

allow-scripts - fix the yarn.lock file

4688525

kumavis force-pushed the allow-scripts branch from 6af2dc6 to 4688525 Compare January 16, 2021 05:58

kumavis added 2 commits January 16, 2021 14:02

ci - fix deps-install script

162bd75

alow-scripts - whitelist scrypt

1a1a112

kumavis marked this pull request as ready for review January 16, 2021 13:37

EtDu added 5 commits February 1, 2021 12:22

Merge branch 'develop' of https://github.com/MetaMask/metamask-extension

238dfe0

into allow-scripts

Merge branch 'allow-scripts' of https://github.com/MetaMask/metamask-…

eb662c5

…extension into allow-scripts

regen lockfile

ac060ab

policy lint

07f894a

remove unused dep

08c5b83

kumavis removed the DO-NOT-MERGE Pull requests that should not be merged label Feb 2, 2021

rekmarks reviewed Feb 2, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

EtDu added 2 commits February 2, 2021 11:22

remove allowScripts entry

d93e584

rm lavamoat dir

67ec7ab

rekmarks reviewed Feb 2, 2021

View reviewed changes

.circleci/scripts/deps-install.sh Outdated Show resolved Hide resolved

Update .circleci/scripts/deps-install.sh

14c3154

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

rekmarks approved these changes Feb 2, 2021

View reviewed changes

rekmarks requested changes Feb 2, 2021

View reviewed changes

rekmarks approved these changes Feb 2, 2021

View reviewed changes

rekmarks merged commit 6b34fb4 into develop Feb 2, 2021

rekmarks deleted the allow-scripts branch February 2, 2021 04:08

github-actions bot locked and limited conversation to collaborators Feb 2, 2021

Conversation

EtDu commented Dec 7, 2020

Uh oh!

github-actions bot commented Dec 7, 2020

Uh oh!

Uh oh!

kumavis commented Dec 8, 2020

Uh oh!

metamaskbot commented Dec 8, 2020

Uh oh!

kumavis left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Dec 8, 2020

Uh oh!

Uh oh!

Uh oh!

kumavis commented Dec 10, 2020

Uh oh!

metamaskbot commented Dec 10, 2020

Uh oh!

metamaskbot commented Jan 16, 2021

Uh oh!

kumavis commented Jan 16, 2021

Uh oh!

rekmarks commented Jan 16, 2021

Uh oh!

kumavis commented Jan 18, 2021

Uh oh!

kumavis commented Feb 2, 2021

Uh oh!

metamaskbot commented Feb 2, 2021

Uh oh!

Uh oh!

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

EtDu commented Feb 2, 2021

Uh oh!

metamaskbot commented Feb 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants