Fixup prop types and use constants#10306
Merged
brad-decker merged 3 commits intodevelopfrom Feb 1, 2021
Merged
Conversation
Collaborator
Builds ready [e0a7810]
Page Load Metrics (665 ± 61 ms)
|
Gudahtt
requested changes
Jan 30, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good aside from one PropType mistake.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Collaborator
Builds ready [960ebba]
Page Load Metrics (748 ± 46 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
design-system.jsconstants file, which contained aSIZESconstant.ColorIndicatorcomponent with its own variety of sizes for its size prop.xs->xltype sizes.xsandxland transformedsmallmediumandlargeinto their two-letter abbreviated counterparts. The size values for those items are unchanged.indicatorSizeandlabelPropsprops to thenetwork-displaycomponent, which is required for the newadd-ethereum-chainrequest UI