Skip to content

Fixup prop types and use constants#10306

Merged
brad-decker merged 3 commits intodevelopfrom
fixup-prop-types
Feb 1, 2021
Merged

Fixup prop types and use constants#10306
brad-decker merged 3 commits intodevelopfrom
fixup-prop-types

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

Rationale

  • in a previous PR I introduced a design-system.js constants file, which contained a SIZES constant.
  • in a PR that predated that one, I added the ColorIndicator component with its own variety of sizes for its size prop.
  • This rectifies the size system to use the xs->xl type sizes.
  • To support that I added entries into the size map for xs and xl and transformed small medium and large into their two-letter abbreviated counterparts. The size values for those items are unchanged.
  • I also added indicatorSize and labelProps props to the network-display component, which is required for the new add-ethereum-chain request UI

@brad-decker brad-decker requested a review from a team as a code owner January 28, 2021 19:41
@brad-decker brad-decker requested a review from darkwing January 28, 2021 19:41
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e0a7810]
Page Load Metrics (665 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded43794966312660
load43895666512661
domInteractive43794966312660

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one PropType mistake.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [960ebba]
Page Load Metrics (748 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint569171115
domContentLoaded4568837469746
load4638857489646
domInteractive4568837469746

@brad-decker brad-decker merged commit 469ccd2 into develop Feb 1, 2021
@brad-decker brad-decker deleted the fixup-prop-types branch February 1, 2021 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants