Skip to content

Update id localized messages#10263

Merged
Gudahtt merged 1 commit intodevelopfrom
update-id-localized-messages
Feb 3, 2021
Merged

Update id localized messages#10263
Gudahtt merged 1 commit intodevelopfrom
update-id-localized-messages

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 23, 2021

These translations were provided by Lionbridge.

@Gudahtt Gudahtt requested a review from a team as a code owner January 23, 2021 04:35
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [69d98f1]
Page Load Metrics (826 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint589274105
domContentLoaded41298582415876
load41498782615876
domInteractive41198482415876

These translations were provided by Lionbridge.
@Gudahtt Gudahtt force-pushed the update-id-localized-messages branch from 69d98f1 to 08928af Compare February 2, 2021 14:47
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [08928af]
Page Load Metrics (553 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735694
domContentLoaded3636535517034
load3686545537034
domInteractive3636525517034

@kumavis
Copy link
Copy Markdown
Member

kumavis commented Feb 3, 2021

i can see this replaces a lot of literal translations with more natural foreign loan words 👍

Copy link
Copy Markdown
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Gudahtt Gudahtt merged commit 20d536d into develop Feb 3, 2021
@Gudahtt Gudahtt deleted the update-id-localized-messages branch February 3, 2021 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants