CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
❌ @adonesky1

I have read the CLA Document and I hereby sign the CLA

Thanks for your feedback @Gudahtt!

Regarding this piece:

• Max mode remains toggled after the user edits the gas amount, which doesn't seem ideal. Ideally max mode would toggle when the user edited the gas amount, so that the user could click "Max" again and go back to the maximum amount. This is probably easiest to accomplish by editing this change handler.

I'm completely new to this codebase so I could very well be missing something but won't the AdvancedGasInputs need to toggle off maxMode in their change handler(s) to produce the desired behavior you describe?

Thanks!

I have read the CLA Document and I hereby sign the CLA

I'm completely new to this codebase so I could very well be missing something but won't the AdvancedGasInputs need to toggle off maxMode in their change handler(s) to produce the desired behavior you describe?

I was thinking of the amount field, not the gas fields. That's an interesting point though 🤔 Maybe it should toggle when gas is edited as well? I think we should leave it for now so that it matches the behaviour of the token send, but that's something worth considering in the upcoming confirmation screen redesign.

But about that request to update the change handler - sorry, you can disregard it completely! I just realized that maxMode is already being untoggled in that handler (via updateAmount), so the behaviour I requested is already present. My mistake.

So all that's left now is to get rid of the unused prop.

Almost there! The e2e tests can be tricky to debug, so I looked into this one. The last test failure is caused by an assertion in our e2e tests that (for some reason) ensures the input element is disabled. That line should be removed.

From line 311 of metamask-ui.spec.js:

assert.equal(await inputAmount.isEnabled(), false)

Ah thanks @Gudahtt! Will do!