Skip to content

Update changelog for v9.0.5#10398

Merged
danjm merged 4 commits intoVersion-v9.0.5from
update-v9.0.5-changelog
Feb 8, 2021
Merged

Update changelog for v9.0.5#10398
danjm merged 4 commits intoVersion-v9.0.5from
update-v9.0.5-changelog

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Feb 8, 2021

No description provided.

@danjm danjm requested a review from a team as a code owner February 8, 2021 14:40
@danjm danjm requested review from Gudahtt and removed request for a team February 8, 2021 14:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt reviewed Feb 8, 2021
View reviewed changes
Gudahtt
Gudahtt reviewed Feb 8, 2021
View reviewed changes
Gudahtt
Gudahtt requested changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two PRs had user-facing changes, but are missing from this changelog:
#10326
#10386

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2021

Builds ready [d90a6d4]
Page Load Metrics (1830 ± 144 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded110422931824300144
load110722961830300144
domInteractive110322881822299144

danjm and others added 3 commits February 8, 2021 12:54
@danjm @Gudahtt
Update CHANGELOG.md
8e0ceaa 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@danjm @Gudahtt
Update CHANGELOG.md
0f19f19 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@danjm
Add changelog entries for #10326 and #10386
00f735d
@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Feb 8, 2021

@Gudahtt your comments have been addressed

Gudahtt
Gudahtt approved these changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2021

Builds ready [00f735d]
Page Load Metrics (897 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6210784147
domContentLoaded66911328959646
load67011338979646
domInteractive66911318959646

brad-decker
brad-decker approved these changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danjm danjm merged commit 9489dbe into Version-v9.0.5 Feb 8, 2021
@danjm danjm deleted the update-v9.0.5-changelog branch February 8, 2021 23:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danjm @metamaskbot @Gudahtt @brad-decker