Implement price impact acknowledgement button#10347
Merged
darkwing merged 1 commit intoMetaMask:developfrom Feb 4, 2021
Merged
Implement price impact acknowledgement button#10347darkwing merged 1 commit intoMetaMask:developfrom
darkwing merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
reviewed
Feb 3, 2021
danjm
reviewed
Feb 3, 2021
Contributor
|
Text alignment and padding can be adjusted to more closely match the designs. Currently, on this branch it looks like Text in the designs seems to be left aligned with only about 10px padding. See https://www.figma.com/file/fDtda1cs3MmPXw1MgKswZc/Development---MetaSwaps?node-id=1868%3A247 |
95c1de9 to
f1be614
Compare
danjm
approved these changes
Feb 4, 2021
Contributor
danjm
left a comment
There was a problem hiding this comment.
Code reviewed and QA'd. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://www.notion.so/airswap/Frontend-cbf9429aaa4d4d2e9ba096f8d2e2b2f0?p=55923589e832413e877f6e0c99066610
Explanation: Implements a button that users must click to acknowledge that their trade could have a huge price impact.