Skip to content

Update ko localized messages#10266

Merged
Gudahtt merged 4 commits intodevelopfrom
update-ko-localized-messages
Feb 2, 2021
Merged

Update ko localized messages#10266
Gudahtt merged 4 commits intodevelopfrom
update-ko-localized-messages

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 23, 2021

These translations were provided by Lionbridge.

@Gudahtt Gudahtt requested a review from a team as a code owner January 23, 2021 04:42
@Gudahtt Gudahtt requested a review from danjm January 23, 2021 04:42
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [6a86646]
Page Load Metrics (1127 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891701122211
domContentLoaded1008126111246230
load1010126711276330
domInteractive1007126111246230

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 25, 2021

If any community contributors would like to help review this PR, it would be greatly appreciated!

I'll tag anyone here that has contributed in the past: @x86kernel @bowbowbow @nujabes403 @hackmod @neutiyoo

I wanted to give you all the opportunity to provide feedback because we owe our current translations to you. Please don't feel obliged if you don't have the time to review, and please let me know if you'd like me to stop tagging you for reviews in the future.

Thanks!

@nujabes403
Copy link
Copy Markdown
Contributor

LGTM

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d456f34]
Page Load Metrics (613 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43685873
domContentLoaded36975161211555
load37175261311555
domInteractive36975061211555

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [71a9f57]
Page Load Metrics (573 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4810162126
domContentLoaded3476865728440
load3496875738440
domInteractive3476865728440

ghost
ghost previously approved these changes Jan 28, 2021
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These translations were provided by Lionbridge.
The sentences did not make sense previously. They have been updated to
be grammatically correct and to emphasize the negation.
@Gudahtt Gudahtt force-pushed the update-ko-localized-messages branch from 71a9f57 to 5e2cbe7 Compare February 2, 2021 14:33
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [5e2cbe7]
Page Load Metrics (626 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint499563115
domContentLoaded4207756246330
load4227766266230
domInteractive4197756246330

@Gudahtt Gudahtt merged commit f9b5b7e into develop Feb 2, 2021
@Gudahtt Gudahtt deleted the update-ko-localized-messages branch February 2, 2021 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2021
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop before merging to ensure that the yourSigRequested message was not present (it was removed in #10300).

Thanks again for the review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants