Refactor NetworkDisplay, ConnectedStatusIndicator, etc to use ColorIndicator#10214
Merged
brad-decker merged 4 commits intodevelopfrom Jan 27, 2021
Merged
Refactor NetworkDisplay, ConnectedStatusIndicator, etc to use ColorIndicator#10214brad-decker merged 4 commits intodevelopfrom
brad-decker merged 4 commits intodevelopfrom
Conversation
8340b19 to
6603f6b
Compare
58e4c35 to
2a7db8d
Compare
6603f6b to
b3026ff
Compare
b39735f to
fdd0f9f
Compare
Collaborator
Builds ready [fdd0f9f]
Page Load Metrics (537 ± 30 ms)
|
Collaborator
Builds ready [a4adbd8]
Page Load Metrics (597 ± 56 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #10209
Explanation: The ColorIndicator component will replace usages of small circles with various color/style treatments. This replaces the various Network Indicators, as well as the connected status indicator circle. Screenshots will be added before coming out of draft
Before
After
Known differences:
Improved accessibility