Conversation
|
hmmm errors in e2e but job passed - that doesn't sound good |
|
just benchmarks failing now 🤔 |
|
@Gudahtt dan said you might be familiar with this benchmark failure? |
|
@kumavis Yep! It's an intermittent failure that I've also seen with the Chrome e2e tests. I had spent some time investigating it, but was unsuccessful in finding an explanation about why it's happening or a solution. IIRC I found reports in the chrome web driver issue tracker where a lot of people had the same issue, and the maintainers were saying it was probably a Chrome bug 🤷. |
|
I tried to re-run it, but now CircleCI is failing 😞 It's claiming we don't have pipelines enabled, but we do... |
Builds ready [7587458]
Page Load Metrics (274 ± 19 ms)
|
|
@Gudahtt reran CI and it passed! Will need to get this up to date, but very encouraging 😁✌️ |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bca98bb to
54149a3
Compare
Builds ready [9a3e91d]
Page Load Metrics (452 ± 72 ms)
|
f2ef73f to
0826d27
Compare
Builds ready [0826d27]
Page Load Metrics (377 ± 43 ms)
|
Builds ready [0826d27]
Page Load Metrics (408 ± 54 ms)
|
|
we should get this merged first MetaMask/core#287 |
|
|
||
| CHROME_VERSION='79.0.3945.117-1' | ||
| CHROME_BINARY="google-chrome-stable_${CHROME_VERSION}_amd64.deb" | ||
| CHROME_BINARY_URL="http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/${CHROME_BINARY}" |
There was a problem hiding this comment.
Huh, so the solution to the intermittent Chrome errors was to install it manually? That is interesting.
IIRC Google doesn't leave this URLs up for long, so we may have to frequently bump this. I recall when I was looking for old Chrome versions, I couldn't find any official sources. Perhaps because Google would prefer everybody update.
There was a problem hiding this comment.
originally we had bumped the chrome version and chromedriver version, causing intermittent failures
@EtDu manually pulls the old chrome version and reverted the chromedriver bump
we should update the chrome/driver pair but its not actually related to this PR
There was a problem hiding this comment.
Well, it's unfortunate that we'll now have to download and install Chrome each time, slowing down CI further. But we already do that for Firefox, so we're not much worse off now.
Someday we'll get around to creating a custom Dockerfile for CI so we can start with the exact build environment we want.
There was a problem hiding this comment.
I believe it's a viable solution for the scope of this PR, but we'll definitely want to create a custom image at some point and figure out why the latest chrome is causing intermittent failures.
Builds ready [10f6324]
Page Load Metrics (368 ± 37 ms)
|
|
I noticed that I guess it makes sense to remove for now either way, since |
|
yeah they were tied to node v10 for some reason i dont remember |
Builds ready [8536fb8]
Page Load Metrics (414 ± 77 ms)
|
Gudahtt
left a comment
There was a problem hiding this comment.
For the sesify-viz removal, the link in the MetaMask bot comment should be removed as well. That is constructed in development/metamaskbot-build-announce.js (seach for deps-viz)
Builds ready [a7235c5]
Page Load Metrics (447 ± 75 ms)
|
Builds ready [76d8f27]
Page Load Metrics (413 ± 80 ms)
|
Builds ready [7fbbdde]
Page Load Metrics (376 ± 67 ms)
|
Builds ready [971fe92]
Page Load Metrics (446 ± 51 ms)
|
Builds ready [971fe92]
Page Load Metrics (482 ± 55 ms)
|
Gudahtt
left a comment
There was a problem hiding this comment.
A few new conflicts have cropped up that need to be resolved. Also there were a few new CI jobs added (for testing metrics) that need to be updated to use Node v14
Builds ready [7c369a2]
Page Load Metrics (370 ± 46 ms)
|
|
did a manual de-conflict since rebase was becoming very painful |
Builds ready [2358abe]
Page Load Metrics (828 ± 11 ms)
|
Builds ready [c18e088]
Page Load Metrics (532 ± 46 ms)
|
dnodeuses a nativeweakrefon node, which fails on node 12. its also almost definitely very mem leaky in the browsernode changelog
https://nodejs.org/en/blog/release/v11.0.0/
https://nodejs.org/en/blog/release/v12.0.0/
https://nodejs.org/en/blog/release/v13.0.0/
https://nodejs.org/en/blog/release/v14.0.0/