Skip to content

chore: 7.21.0 main sync#9409

Merged
sethkfman merged 69 commits intorelease/7.21.0from
chore/7.21.0-main-sync
Apr 25, 2024
Merged

chore: 7.21.0 main sync#9409
sethkfman merged 69 commits intorelease/7.21.0from
chore/7.21.0-main-sync

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

Description

This PR resolves the merge conflicts between 7.21.0 release branch and main.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gantunesr and others added 30 commits April 12, 2024 08:38
Adds a patch solution to prevent the HD keyring being removed from the `@metamask/eth-keyring-controller` state.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Update the read me to include the correct path to Android SDK

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

There have been type errors showing up on some PRs relating to image
imports; TypeScript interprets them as strings, but we have them typed
as `ImageSourcePropType`. The mismatch is there because these image
imports are modified later in the build system.

Normally this is handled by our type declarations, which declare upfront
which types these imports should have. But on some PRs, it seems that
TypeScript will evaluate these declarations too late, after files
including image imports.

I had trouble reproducing this problem on `main`, but it can be seen in
the PR #8828 (commit b027cfa). If you
include this change on that branch, it resolves the problem.

## **Related issues**

Resolves lint error on #8828

## **Manual testing steps**

Patch this change onto #8828 and see that the `yarn lint:tsc` command
succeeds

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**
This PR addresses the update to the Asset Controller v14

Created Core branch to address patch changes:
patch/mobile-assets-controllers-v-14-0-0

Fixed issue of token being automatically imported when requested by a
dapp.

Changed breaking changes on addToken and watchAsset function signature.

Important to note that this version of assets controller is pointing to
version 5 of controller utils, therefore the auto detect tokens will
only be available when this
[PR](#9149) is merged

## **Related issues**

Fixes: MetaMask/mobile-planning#1620

## **Manual testing steps**

1. imported tokens on mainnet
2. Imported tokens on custom network
3. Auto-detect tokens on mainnet & custom network
4. Import token via dapp
5.

## **Screenshots/Recordings**

Auto detect tokens, import token via dapp:


https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9


Add custom token/ hide token:



https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
…Bridge` (#9216)

## **Description**

The `SubjectType` for origins connecting via the `BackgroundBridge` was
incorrectly set to `SubjectType.Snap` for all origins. This PR corrects
it to assuming that all origins are of type `SubjectType.Website`.

This is important in order to enforce that Snap-specific RPC methods
don't leak into the possession of dapps.
## **Description**

Updated the patch accordingly, and introduced networkIds list hardcoded
for we keep the ens legacy functions working

* The patch controller-utils would be able to be removed on v8 and v9 of
controller-utils
* Added a temporary resolution for the dependency of transaction
controller controller utils be bumped to version 5 to keep linea sepolia
transactions working. It will be removed when transaction controller be
updated to v13
* This PR needs assets controller
[PR](#9182) v14 be
merged to have auto nfts detection working

## **Related issues**

Fixes: MetaMask/mobile-planning#1622

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

ENS solving: 


https://github.com/MetaMask/metamask-mobile/assets/46944231/bb8eecd4-951d-427f-9356-9b4ba0e65a0d


Sepolia linea network:

Uploading Screen Recording 2024-04-11 at 11.16.38.mov…


NFT auto detection working


https://github.com/MetaMask/metamask-mobile/assets/46944231/ce4efcf8-5678-4b7b-965a-30499db67e17




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes missing pod updates from a PR with notifications changes
#8701
This updates both the Xcode project file as well as Podfile.lock

cc: @Jonathansoufer 

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

PR to migrate users to linea Sepolia if they are on linea-goerli. And
remove linea goerli from default network list because its deprecated.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Build on main
2. Switch to linea-goerli
3. Build on this PR
4. You should be on linea sepolia instead of linea goerli
5. You can add linea goerli by clicking on the navigation button in the
wallet and type in: chainlist.org. Connect your wallet and you can look
for the network you want to add then click on "add to metamask" button.
(I used this RPc url https://59140.rpc.thirdweb.com to add linea goerli)
6.You should see deprecation warning for linea goerli. And you should be
able to see any previous transactions you did.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

Linea goerli appears on the default network list.
I make few transactions on both linea goerli and linea sepolia.


https://github.com/MetaMask/metamask-mobile/assets/10994169/c0e621ce-9cd3-47e8-b653-cc19f1413796



### **After**

I add manually linea goerli and i can see transactions i already did.


https://github.com/MetaMask/metamask-mobile/assets/10994169/db6c910b-4ba7-4559-8850-33472a883ff6


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**
Add typescript error expected to controllers of assets controllers that
use the getNetworkType property.

There are no breaking changes on this update so it makes it very small.
The patch was updated accordingly.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**



https://github.com/MetaMask/metamask-mobile/assets/46944231/125c635d-f374-4329-a636-a3cd78089022



<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Cal Leung <cleun007@gmail.com>
## **Description**

Gas fee controller updated to version ^7


## **Related issues**

Fixes: MetaMask/mobile-planning#1623

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
# This is the release candidate for version 7.20.0.
- [Release
Tracker](https://docs.google.com/spreadsheets/d/1tsoodlAlyvEUpkkcNcbZ4PM9HuC9cEM80RZeoVv5OCQ/edit#gid=2124987401&range=A1)

# Teams with Changes
- Accounts: @michael.berardi - 2 changes
- Confirmation UX: @mariona.farell - 7 changes
- Ramps: @brendan.kirby - 3 changes
- Hardware Wallets: @leo.wang - 3 changes
- SDK: @christopher.ferreira - 2 changes
- Security: @nicholas.ellul - 1 change
- Snaps: @jonathan.ferreira - 1 change

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: sethkfman <seth.kaufman@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>
Co-authored-by: CW <chris.wilcox@consensys.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Owen Craston <owen.craston@consensys.net>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Kylan Hurt <kylanhurt@users.noreply.github.com>
Co-authored-by: Xiaoming Wang <dawnseeker8@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: Curtis David <Curtis.David7@gmail.com>
Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
Co-authored-by: Omridan159 <omridan159@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: salimtb <salim.toubal@outlook.com>
Co-authored-by: João Loureiro <1649425+jpcloureiro@users.noreply.github.com>
Co-authored-by: Aslau Mario-Daniel <marioaslau@gmail.com>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Amélie <amelie.chan@gmail.com>
Co-authored-by: Omri Dan <61094771+omridan159@users.noreply.github.com>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: SamuelSalas <samuel.salas.reyes@gmail.com>
Co-authored-by: tommasini <tommasini15@gmail.com>
Co-authored-by: Kylan Hurt <kylan.hurt@gmail.com>
Co-authored-by: Nicholas Ellul <nicholas.ellul1@gmail.com>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Co-authored-by: Jonathan Ferreira <44679989+Jonathansoufer@users.noreply.github.com>
Co-authored-by: Mpendulo Ndlovu <mpendulo@elefantel.com>
Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Priya <priya.narayanaswamy@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**


https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d01b2c5b-7295-4aba-bd80-9abb4c7939ae

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Cal Leung <cleun007@gmail.com>
## **Description**

We should send PPOM/Blockaid metrics parameters when a transaction from
wallet is rejected. Right now we only send the metrics when the
transaction is approved.

## **Related issues**

Fixes: [#8824](#8824)

## **Manual testing steps**

1. Enable Blockiad
2. Enable metrics
3. Initiate a malicious tx from inside the wallet
4. Cancel/Reject the transaction
5. See that PPOM Metrics is sent in the logs

## **Screenshots/Recordings**

### **Before**


https://github.com/MetaMask/metamask-mobile/assets/54408225/12153f52-baeb-4344-b6f6-0c00c2a1d1fc

### **After**


https://github.com/MetaMask/metamask-mobile/assets/44811/efea6aa9-96f7-4b57-915c-5fe946daabdf

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
## **Description**

`eth-json-rpc-errors` was renamed to `eth-rpc-errors` in 2020.

metamask-mobile is still pulling in both packages. This removes
deprecated `eth-json-rpc-errors` and replaces references with
`eth-rpc-errors`.
- removes @ethereumjs/common dependency (usage and package import)
- updates indirect dependencies not locked anymore
- fixes export and imports of buildUnserializedTransaction function
- dedup updated yarn lock

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
…9243)

## **Description**

Fixes #9242 and
#9244

More specifically, fixes these 2 issues:

- URL not called properly for Stake button since constant name changes
(broken Portfolio Stake link)
- `isPortfolioUrl` is not imported in app/components/UI/Tokens/index.tsx
(broken Portfolio home link)

**NOTE**: These [breaking
issues](#8674) should
have been caught by the typechecker which is [currently disabled for the
components
folder](https://github.com/MetaMask/metamask-mobile/blob/ef475b788f9be7f0d2b66ea749045772ed899ba0/tsconfig.lint.json#L11).
I'd strongly advise that this is re-implemented as these issues could
have been easily been caught at the commit or CI level.

## **Related issues**

Fixes: #9242 and
#9244

## **Manual testing steps**

- Go to Token Listing
- Verify that the new staking icon shows up on ETH on mainnet
- Verify that onPress, the MM browser opens up the Portfolio stake page
with the correct query params
(https://portfolio.metamask.io/stake?metamaskEntry=mobile)
- Verify that if a browser tab is already open on the stake page, the MM
browser picks this tab rather than opening a new one
- Verify that the Token Listing Portfolio button opens up the portfolio
page (https://portfolio.metamask.io?metamaskEntry=mobile) and does not
crash the app

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/MetaMask/metamask-mobile/assets/22345430/05d258d8-e962-4297-9e2d-b6f7a47f688f

### **After**


https://github.com/MetaMask/metamask-mobile/assets/22345430/8b7cdca4-1028-45e3-8da8-074d80e70755

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
…' Method (#9236)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
*This is a fix to this Issue:
https://github.com/MetaMask/mobile-planning/issues/1520

This pull request enhances the `parseDeeplink` method by adding robust
URL validation and error handling.
Key improvements include:

- `URL Validation`: Ensures only correctly formatted URLs are processed
to prevent errors during deep linking.
- `Error Handling`: Captures exceptions with updated error handling, and
alerting users to invalid URLs via a `react-native` alert.

These updates aim to improve the security and user experience by
preventing the processing of malformed URLs and providing immediate
feedback on errors.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

Available in this Issue:
https://github.com/MetaMask/mobile-planning/issues/1520

<!-- [screenshots/recordings] -->

### **After**


https://github.com/MetaMask/metamask-mobile/assets/61094771/676e6f9e-663f-4bfb-8e23-43f24365c07d


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: witmicko <witmicko@users.noreply.github.com>
## **Description**

The palm logo needed updating, it was confirmed that the logo used in
the extension was the correct one.

## **Related issues**

Fixes:

## **Manual testing steps**

In the header, select the network to bring up the change network bottom
list, click on Add network, the Palm logo should be visible next to the
Palm network (if the network is part of the networks that can be added).

## **Screenshots/Recordings**

| With old logo  | The new logo | With new logo  |
|----------|----------|----------|
| ![Image
1](https://github.com/MetaMask/metamask-mobile/assets/165834542/fa0377a9-a450-48ab-b122-a43a9c269c32)
| ![Image
2](https://github.com/MetaMask/metamask-mobile/assets/165834542/5250f59a-3ea0-41c0-afa1-c115b41e8a53)
| ![Image
3](https://github.com/MetaMask/metamask-mobile/assets/165834542/98150829-95a8-4e40-9419-708087015fa9)
|




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

The previous link to the privacy policy was specific to metamask. It was
decided (by legal team) that the consensys privacy policy should be
shown.


## **Related issues**

Fixes:

## **Manual testing steps**

1. Create a new account
2. During the onboarding flow, at the privacy policy step, click the
last link to show the updated privacy policy.
3. There is also another place where this link is present Options->About
Metamask->Privacy Policy

## **Screenshots/Recordings**

| Before (from settings menu) | After (from settings menu) | After (from
onboarding flow) |
|----------|----------|----------|
| ![Image
1](https://github.com/MetaMask/metamask-mobile/assets/165834542/4bdea991-b009-4130-90c8-4464dca21ec0)
| ![Image
2](https://github.com/MetaMask/metamask-mobile/assets/165834542/545e04cc-25e0-4b3a-b33d-1479e3a83640)
| ![Image
3](https://github.com/MetaMask/metamask-mobile/assets/165834542/aa349ef5-b056-4f87-8d6c-227099b2a850)
|



### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

When swapping a token that needs approval (and requires a 2 step swap
process), it's needed for the user, when using a hardware wallet, to
manually sign transactions. Currently, second modal opening is triggered
when approval transaction is finished (meaning when it has been
submitted). But this would end up in a situation where the first modal
was not unmounted before it was asked to be mounted again. This flow was
creating an issue where the user could not confirm the second
transaction (as second modal was never displayed)

To mitigate this issue, we choose to wait for first transaction
completion before starting the second one. This is not perfect from user
POV as a long delay can happen between approval and swap txs, but as
discussed with @AlexJupiter and @gantunesr it's considered as a
temporary solution until we figure out a long term one.

## **Related issues**

Fixes: #8667

## **Manual testing steps**
For ease the explanation, we are using `AAVE` and `MATIC` on Polygon
network and will sign txs with a Ledger account. You also need blind
signing to be enabled on your Ledger device.

1. make sure `AAVE` token approval has been revoked here
https://polygonscan.com/tokenapprovalchecker for your Ledger account
2. select swap action from actions dropdown
3. select your Ledger account
4. select `AAVE` token as origin token
5. type a value that you want to swap (`0.0000001` is fine)
6. select `MATIC` token as destination token
7. get quotes (you may need to retry several times this step)
8. Swipe to swap
9. First modal should be displayed. Sign approval tx on your ledger
device
10. Once approval txs is confirmed, second modal is opening. Sign swap
tx on your ledger device
11. Swap should be completed

## **Screenshots/Recordings**

### **Before**
https://recordit.co/Vg7MLtediW

### **After**

https://github.com/MetaMask/metamask-mobile/assets/574787/fbe01613-2dd5-4762-98f6-4072782e7491


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
…9142)

## **Description**

- New  definition added to labelling guidelines: `regression-develop`.
- Same PR on Extension reop:
MetaMask/metamask-extension#23855

## **Related issues**

- Fixes: None

## **Manual testing steps**

- None

## **Screenshots/Recordings**

- Preview available here:
https://github.com/MetaMask/metamask-mobile/blob/efaf3bb3fe2d36219f67345dd921cd9e890944fd/.github/guidelines/LABELING_GUIDELINES.md

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

- Issue with `generateRawSignature` that didn't include the
`isWalletConnect` property.
- Issue undetected because of a missing type (set as any) in the method
signature.

## **Related issues**

Fixes: #9246

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Invalid url when using in-app browser.

## **Related issues**

Fixes: #9259

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
… focused translation (#8565)

This allows for branch/PR focused translations

## **Description**

Currently, translation only happens once changes to the en.json file are
merged to main. These changes could include new keys being added or
changes to english text. What this means is that there is no way
currently to require that translations be in place before the feature
goes live. It could make it through translation before being released
but there is currently no way to require that we wait for translations.

## **Related issues**

Fixes: [8564](#8564)

## **Manual testing steps - To be done after merge and with Desi**
**Use case 1 (feature branch requires translation):**

- Developer creates a branch for feature which requires translations
- They add keys or change english source and when they are ready for
translations to be done they create a PR and add the label
“ready-for-translation”
- Manually trigger crowdin-branch-pr-ready-for-translation.yml ON THE
BRANCH
- Confirm branch created in crowdin with just the untranslated keys
(plus any untranslated ones from main or any translated but not merged
keys from main) - This is where we could get confusion on the BLEND
side.
- Wait for translations (Desi will likely have to talk to BLEND to let
them know what we are doing and get these translations done so that we
can finish out the test)
- Manually trigger the translation check before translations complete
(confirm no translation PR created)
- Manually trigger the translation check after translations complete
(confirm PR created off this branch)
- Merge translation PR into branch, manually remove label (later PR will
do this automatically), manually delete localization branch for this
branch (later PR will do this automatically)
- Merge PR for feature to main
- Manually trigger crowdin-upload-both-sources-translations.yml and
ensure translations show on main in crowdin.
- Manually trigger crowdin-branch-cleanup.yml and make sure the branch
is removed from crowdin

**Use Case 2 (main branch translations):**

- Developer is working just normally and adds new keys or changes
english version in some way.
- They go through normal PR flow once they merge to main
- Manually trigger crowdin-upload-both-sources-translations.yml
- Confirm new keys are on main
- Work with Blend to get one thing translated so we can see
crowdin-pull-branch-pr-completed-translations.yml pull down the partial
translation
- Manually trigger crowdin-pull-branch-pr-completed-translations.yml and
check the localization PR has the translations.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
## **Description**

This PR adds a permission flag on e2e init file so that Notification
native dialog don't shows up.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

This PR implements all translations needed for Notifications feature.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**
More info
[here](MetaMask/MetaMask-planning#2278)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**
Added new allowed actions to the gas fee controller initialization on
engine file to support getNetworkClientById and getEIP1559Compatibility
actions

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Update Phishing Controller to version 8.0.0

While the initial issue was to update the Phishing Controller to v7.0.0,
it had to be bumped to v8.0.0 due to a bug that was taking place in
previous versions.

Issue: MetaMask/mobile-planning#1625
e2e:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91be008e-79fe-4b2b-8fae-b4d34f644498

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->


https://github.com/MetaMask/metamask-mobile/assets/15312578/26cccd57-87b7-4586-9d21-7a839c15956c

a

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
frankvonhoven and others added 6 commits April 24, 2024 17:16
## **Description**

Fix failing regression e2e tests after merging #9208 

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
… repo (#9395)

## **Description**

Testing is being done via another repo and I accidentally brought over a
hard coded url from that repo. :(

## **Related issues**

Fixes:

## **Manual testing steps**

1. Manual tested in other repo
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
…9384)

The referenced version of dependency `react-native-animated-fox` has
been published on NPM registry as `@metamask/react-native-animated-fox`.

This replaces the `git+https://github.com` reference with the published
package.
## **Description**

We are aiming to refactor the page objects in the modal folder so that
they strictly follow the page object model pattern. This would aide in
providing more readable and help standardize the way we create our
tests. Because of the amount of files inside of the modal folder, the
scope was divided into a batch of 4.

Files inside the scope for this batch:
- NetworkEducationModal.js
- NetworkListModal.js
- OnboardingWizardModal.js
- ProtectYourWalletModal.js
- RequestPaymentModal.js

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

Regression test run:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a21ca4f5-9020-47e1-9b2b-97b49d4b5ddd

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sethkfman sethkfman requested a review from a team as a code owner April 25, 2024 15:28
@sethkfman sethkfman requested a review from a team April 25, 2024 15:28
@sethkfman sethkfman requested review from a team as code owners April 25, 2024 15:28
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/on-ramp-sdk@1.27.1 Transitive: unsafe +4 906 kB pmkowalski
npm/@metamask/gas-fee-controller@10.0.1 Transitive: environment, network +21 1.58 MB metamaskbot
npm/@metamask/json-rpc-engine@7.3.3 None +1 105 kB metamaskbot
npm/@metamask/keyring-controller@9.0.0 None +22 1.61 MB metamaskbot
npm/@metamask/network-controller@15.2.0 environment +6 848 kB metamaskbot
npm/@metamask/react-native-animated-fox@2.1.0 None 0 31.9 kB lgbot
npm/@metamask/react-native-splash-screen@3.2.0 None 0 39 kB gudahtt
npm/@noble/hashes@1.4.0 None 0 773 kB paulmillr
npm/@scure/base@1.1.6 None 0 80.4 kB paulmillr
npm/@spruceid/siwe-parser@2.1.0 None 0 36.3 kB sbihel
npm/apg-js@4.2.0 filesystem 0 1.45 MB ldthomas
npm/axios@1.6.8 network +1 1.87 MB jasonsaayman
npm/contentful@10.8.7 environment, eval, filesystem, network +9 2.46 MB contentful-ecosystem
npm/ethereum-cryptography@2.1.3 None +2 517 kB paulmillr
npm/sshpk@1.18.0 Transitive: environment, filesystem +7 612 kB bahamat
npm/web3-provider-engine@16.0.8 Transitive: environment, eval, filesystem, network +45 5.89 MB lgbot

🚮 Removed packages: npm/@consensys/on-ramp-sdk@1.26.8, npm/@metamask/gas-fee-controller@6.1.2, npm/@metamask/json-rpc-engine@7.3.2, npm/@metamask/keyring-controller@8.1.0, npm/@metamask/phishing-controller@6.0.1, npm/@noble/curves@1.1.0, npm/@scure/base@1.1.3, npm/axios@1.6.0, npm/eth-json-rpc-errors@2.0.2, npm/react-native-animated-fox@2.0.1, npm/react-native-splash-screen@3.2.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 25, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@consensys/on-ramp-sdk@1.27.1, npm/@contentful/rich-text-types@16.3.5, npm/@cypress/request@3.0.1, npm/@metamask/eth-json-rpc-infura@6.0.0, npm/@metamask/eth-json-rpc-provider@2.3.2, npm/@metamask/eth-keyring-controller@15.1.0, npm/@metamask/gas-fee-controller@10.0.1, npm/@metamask/json-rpc-engine@7.3.3, npm/@metamask/keyring-controller@9.0.0, npm/@metamask/network-controller@15.2.0, npm/@metamask/network-controller@16.0.0, npm/@metamask/polling-controller@1.0.2, npm/@metamask/react-native-animated-fox@2.1.0, npm/@metamask/react-native-splash-screen@3.2.0, npm/@noble/hashes@1.4.0, npm/@scure/base@1.1.6, npm/@scure/bip32@1.3.3, npm/@scure/bip39@1.2.2, npm/@spruceid/siwe-parser@2.1.0, npm/apg-js@4.2.0, npm/axios@1.6.8, npm/contentful-resolve-response@1.8.1, npm/contentful-sdk-core@8.1.2, npm/contentful@10.8.7, npm/eth-json-rpc-filters@5.0.0, npm/eth-json-rpc-middleware@8.1.0, npm/ethereum-cryptography@2.1.3, npm/fast-copy@2.1.7, npm/http-signature@1.3.6, npm/jsprim@2.0.2, npm/lodash.isstring@4.0.1, npm/p-throttle@4.1.1, npm/qs@6.10.4, npm/sshpk@1.18.0, npm/type-fest@4.15.0, npm/web3-provider-engine@16.0.8

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3a248f2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60541a32-4183-46a7-9198-e60208e7ea32

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all

This is a release PR everything has been vetted before getting into main

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 24ada3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b0bfcd6-689c-4bef-a85e-e26c497856d3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

@sethkfman sethkfman merged commit a6b240d into release/7.21.0 Apr 25, 2024
@sethkfman sethkfman deleted the chore/7.21.0-main-sync branch April 25, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.21.0 on PR, as PR was added to branch 7.21.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.