Skip to content

fix: e2e test permission problem#9302

Merged
cortisiko merged 1 commit intomainfrom
fix/e2e-tests
Apr 17, 2024
Merged

fix: e2e test permission problem#9302
cortisiko merged 1 commit intomainfrom
fix/e2e-tests

Conversation

@Jonathansoufer
Copy link
Copy Markdown
Contributor

@Jonathansoufer Jonathansoufer commented Apr 17, 2024

Description

This PR adds a permission flag on e2e init file so that Notification native dialog don't shows up.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Apr 17, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner April 17, 2024 22:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added team-mobile-platform Mobile Platform team Run Smoke E2E team-notifications-deprecated DEPRECATED: please use "team-assets" instead labels Apr 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0944484
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9a08ad1-6706-4c3a-a56d-98278a06ac01

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

cortisiko
cortisiko approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@cortisiko cortisiko merged commit a9eef46 into main Apr 17, 2024
@cortisiko cortisiko deleted the fix/e2e-tests branch April 17, 2024 23:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jonathansoufer @cortisiko @metamaskbot