feat: update phishing controller v8.0.0#9271
Merged
MarioAslau merged 6 commits intomainfrom Apr 18, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/phishing-controller@6.0.1 |
legobeat
previously requested changes
Apr 17, 2024
Contributor
legobeat
left a comment
There was a problem hiding this comment.
There is no such thing as PhishingState anymore.
https://github.com/MetaMask/metamask-mobile/actions/runs/8713996348/job/23903475706?pr=9271
'"@metamask/phishing-controller"' has no exported member named 'PhishingState'. Did you mean 'PhishingListState'?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Phishing Controller to version 8.0.0
While the initial issue was to update the Phishing Controller to v7.0.0, it had to be bumped to v8.0.0 due to a bug that was taking place in previous versions.
Issue: https://github.com/MetaMask/mobile-planning/issues/1625
e2e: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91be008e-79fe-4b2b-8fae-b4d34f644498
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Recording.8.mp4
a
Pre-merge author checklist
Pre-merge reviewer checklist