Skip to content

fix(labeling guidelines): Add definition of regression-develop label#9142

Merged
gauthierpetetin merged 1 commit intomainfrom
fix/labeling-guidelines-regression-develop
Apr 17, 2024
Merged

fix(labeling guidelines): Add definition of regression-develop label#9142
gauthierpetetin merged 1 commit intomainfrom
fix/labeling-guidelines-regression-develop

Conversation

@gauthierpetetin
Copy link
Copy Markdown
Contributor

@gauthierpetetin gauthierpetetin commented Apr 4, 2024

Description

Related issues

  • Fixes: None

Manual testing steps

  • None

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Apr 4, 2024
@gauthierpetetin gauthierpetetin self-assigned this Apr 4, 2024
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner April 4, 2024 17:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added product-backlog needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed product-backlog labels Apr 4, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

gauthierpetetin added a commit to MetaMask/metamask-extension that referenced this pull request Apr 17, 2024
…23855)

## **Description**

- New  definition added to labelling guidelines: `regression-develop`.
- Same PR on Mobile repo:
MetaMask/metamask-mobile#9142

## **Related issues**

- Fixes: None

## **Manual testing steps**

- None

## **Screenshots/Recordings**

- Preview available here:
https://github.com/MetaMask/metamask-extension/blob/08c910cf750017d0bf586a28578dbfad8d6599c1/.github/guidelines/LABELING_GUIDELINES.md

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@gauthierpetetin gauthierpetetin merged commit 67e6fcc into main Apr 17, 2024
@gauthierpetetin gauthierpetetin deleted the fix/labeling-guidelines-regression-develop branch April 17, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants