Skip to content

fix(labeling guidelines): Add definition of regression-develop label#23855

Merged
gauthierpetetin merged 1 commit intodevelopfrom
fix/labeling-guidelines-regression-develop
Apr 17, 2024
Merged

fix(labeling guidelines): Add definition of regression-develop label#23855
gauthierpetetin merged 1 commit intodevelopfrom
fix/labeling-guidelines-regression-develop

Conversation

@gauthierpetetin
Copy link
Copy Markdown
Contributor

@gauthierpetetin gauthierpetetin commented Apr 4, 2024 •
edited
Loading

Description

Related issues

  • Fixes: None

Manual testing steps

  • None

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin added the team-extension-platform Extension Platform team label Apr 4, 2024
@gauthierpetetin gauthierpetetin self-assigned this Apr 4, 2024
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner April 4, 2024 17:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2024
@gauthierpetetin gauthierpetetin mentioned this pull request Apr 4, 2024
Merged
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (9e21127) to head (08c910c).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23855   +/-   ##
========================================
  Coverage    69.02%   69.02%           
========================================
  Files         1164     1164           
  Lines        44513    44513           
  Branches     11890    11890           
========================================
  Hits         30721    30721           
  Misses       13792    13792

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 4, 2024

Builds ready [08c910c]
Page Load Metrics (767 ± 454 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint642891276029
domContentLoaded98725199
load532297767945454
domInteractive98725199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review April 10, 2024 20:31
hjetpoluru
hjetpoluru approved these changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin merged commit 8560878 into develop Apr 17, 2024
@gauthierpetetin gauthierpetetin deleted the fix/labeling-guidelines-regression-develop branch April 17, 2024 01:05
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hjetpoluru hjetpoluru hjetpoluru approved these changes

+1 more reviewer

@bergeron bergeron bergeron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gauthierpetetin gauthierpetetin

Labels

release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gauthierpetetin @metamaskbot @bergeron @hjetpoluru