fix: correct SubjectType for origins connecting via the BackgroundBridge#9216
Merged
FrederikBolding merged 1 commit intomainfrom Apr 12, 2024
Merged
Conversation
SubjectType for origins connecting via the BackgroundBridgeSubjectType for origins connecting via the BackgroundBridge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
SubjectTypefor origins connecting via theBackgroundBridgewas incorrectly set toSubjectType.Snapfor all origins. This PR corrects it to assuming that all origins are of typeSubjectType.Website.This is important in order to enforce that Snap-specific RPC methods don't leak into the possession of dapps.