feat: Update controller utils to 5.0.2 by tommasini · Pull Request #9149 · MetaMask/metamask-mobile

tommasini · 2024-04-05T12:40:31Z

Description

Updated the patch accordingly, and introduced networkIds list hardcoded for we keep the ens legacy functions working

The patch controller-utils would be able to be removed on v8 and v9 of controller-utils
Added a temporary resolution for the dependency of transaction controller controller utils be bumped to version 5 to keep linea sepolia transactions working. It will be removed when transaction controller be updated to v13
This PR needs assets controller PR v14 be merged to have auto nfts detection working

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1622

Manual testing steps

Go to this page...

Screenshots/Recordings

ENS solving:

Screen.Recording.2024-04-11.at.11.15.53.mov

Sepolia linea network:

Uploading Screen Recording 2024-04-11 at 11.16.38.mov…

NFT auto detection working

Screen.Recording.2024-04-12.at.14.23.43.mov

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…duced networkIds list hardcoded for we keep the ens legacy functions working

…ia logic

github-actions · 2024-04-05T12:40:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…or controller utils package

github-actions · 2024-04-11T10:25:23Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 570d896
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2441e11-f9f7-4f50-a2dc-e1f77458c51e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-11T12:10:18Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f67d448
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc153ebb-a144-49e6-8378-e8d9b4b5a59f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

## **Description** This PR addresses the update to the Asset Controller v14 Created Core branch to address patch changes: patch/mobile-assets-controllers-v-14-0-0 Fixed issue of token being automatically imported when requested by a dapp. Changed breaking changes on addToken and watchAsset function signature. Important to note that this version of assets controller is pointing to version 5 of controller utils, therefore the auto detect tokens will only be available when this [PR](#9149) is merged ## **Related issues** Fixes: MetaMask/mobile-planning#1620 ## **Manual testing steps** 1. imported tokens on mainnet 2. Imported tokens on custom network 3. Auto-detect tokens on mainnet & custom network 4. Import token via dapp 5. ## **Screenshots/Recordings** Auto detect tokens, import token via dapp: https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9 Add custom token/ hide token: https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-04-12T13:27:44Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 67e71fb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/732d3a02-d010-407d-a2af-795e44ad9f10

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

## **Description** This PR addresses the update to the Asset Controller v14 Created Core branch to address patch changes: patch/mobile-assets-controllers-v-14-0-0 Fixed issue of token being automatically imported when requested by a dapp. Changed breaking changes on addToken and watchAsset function signature. Important to note that this version of assets controller is pointing to version 5 of controller utils, therefore the auto detect tokens will only be available when this [PR](#9149) is merged ## **Related issues** Fixes: MetaMask/mobile-planning#1620 ## **Manual testing steps** 1. imported tokens on mainnet 2. Imported tokens on custom network 3. Auto-detect tokens on mainnet & custom network 4. Import token via dapp 5. ## **Screenshots/Recordings** Auto detect tokens, import token via dapp: https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9 Add custom token/ hide token: https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sonarqubecloud · 2024-04-12T13:37:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MarioAslau

Looks great Tomas! Thank you for giving some context

tommasini added 6 commits March 27, 2024 18:02

Update controller utils to 5.0.2, update the patch accordingly, intro…

746e26d

…duced networkIds list hardcoded for we keep the ens legacy functions working

Update patch controller utils, the types file was missing linea sepol…

a3c576c

…ia logic

removed unnecessary network ids

f2746f4

add ^ to dependency of controller utils

ba3af01

handle ts issue

c09c6d6

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

b239d93

tommasini mentioned this pull request Apr 5, 2024

feat: Update controller utils to 5.0.2 #9079

Merged

7 tasks

tommasini and others added 2 commits April 9, 2024 21:26

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

bf3db89

merge main and solve conflicts

bc7a2eb

tommasini added the team-mobile-platform Mobile Platform team label Apr 10, 2024

added resolutions for assets controllers and transaction controller f…

c09c337

…or controller utils package

tommasini mentioned this pull request Apr 11, 2024

feat: Update assets controllers v14 #9182

Merged

7 tasks

tommasini and others added 3 commits April 11, 2024 10:23

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

4b7457f

remove non needed resolution for assets controllers

84f9cec

address ts error

570d896

tommasini marked this pull request as ready for review April 11, 2024 10:23

tommasini requested a review from a team April 11, 2024 10:23

tommasini requested a review from a team as a code owner April 11, 2024 10:23

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Apr 11, 2024

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

f67d448

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Apr 11, 2024

tommasini added 2 commits April 12, 2024 14:12

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

94cd255

remove ts expect error unnecessary

bec5931

tommasini removed the Run Smoke E2E label Apr 12, 2024

tommasini added the Run Smoke E2E label Apr 12, 2024

Merge branch 'main' into feat/1622-controller-utils-v5-0-2

67e71fb

MarioAslau approved these changes Apr 12, 2024

View reviewed changes

tommasini merged commit 5440541 into main Apr 12, 2024

tommasini deleted the feat/1622-controller-utils-v5-0-2 branch April 12, 2024 14:34

github-actions bot locked and limited conversation to collaborators Apr 12, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2024

metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Update controller utils to 5.0.2#9149

feat: Update controller utils to 5.0.2#9149
tommasini merged 16 commits intomainfrom
feat/1622-controller-utils-v5-0-2

tommasini commented Apr 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 5, 2024

Uh oh!

github-actions bot commented Apr 11, 2024 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Apr 11, 2024 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

MarioAslau left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tommasini commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 5, 2024

Uh oh!

github-actions bot commented Apr 11, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Apr 11, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Apr 12, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate passed

Uh oh!

MarioAslau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tommasini commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

Loading