Skip to content

7.20.0#9100

Merged
Cal-L merged 18 commits intomainfrom
release/7.20.0
Apr 16, 2024
Merged

7.20.0#9100
Cal-L merged 18 commits intomainfrom
release/7.20.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 29, 2024

This is the release candidate for version 7.20.0.

Teams with Changes

  • Accounts: @michael.berardi - 2 changes
  • Confirmation UX: @mariona.farell - 7 changes
  • Ramps: @brendan.kirby - 3 changes
  • Hardware Wallets: @leo.wang - 3 changes
  • SDK: @christopher.ferreira - 2 changes
  • Security: @nicholas.ellul - 1 change
  • Snaps: @jonathan.ferreira - 1 change

@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. team-mobile-platform Mobile Platform team labels Mar 29, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 29, 2024
@chrisleewilcox
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.98%. Comparing base (3f17ad2) to head (f45c2c5).
Report is 15 commits behind head on main.

Files Patch % Lines
app/components/Nav/Main/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9100      +/-   ##
==========================================
+ Coverage   45.35%   45.98%   +0.63%     
==========================================
  Files        1272     1273       +1     
  Lines       31247    31342      +95     
  Branches     3189     3213      +24     
==========================================
+ Hits        14171    14414     +243     
+ Misses      16234    16079     -155     
- Partials      842      849       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini and others added 2 commits April 4, 2024 08:16
## **Description**
This reverts commit 6e87690. Can access the
[PR](#9123) here

Revert  Update controller utils to 5.0.2 

The controller util dependency of network controller v12 is on v4 and
it's not getting the patch with linea sepolia code applied, which makes
updating the controller utils dependent of network controller v13
update, for simplicity we will revert this
[PR](#9079) and then
merge it after network controller v13
[PR](#9065) is merged

## **Related issues**

Fixes: #9111

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**



https://github.com/MetaMask/metamask-mobile/assets/46944231/6e3ce0e2-ad7e-444d-b496-58822da3ad8f

Sendflow & dapp transaction



https://github.com/MetaMask/metamask-mobile/assets/46944231/38ea2ccd-b3f1-48d5-b867-00c5d7cb0507



### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
This PR cherry picks
#9125

Co-authored-by: CW <chris.wilcox@consensys.net>
@Bullcoiner
Copy link
Copy Markdown

Bullcoiner commented Apr 4, 2024

Android 7.20 (1293) QA Testing

Onboarding: custom ETH mainnet
✅ Custom mainnet Scenario 1: Verifying the custom mainnet screen appears (works, but not visible in video due to black security screen)
✅ Custom mainnet Scenario 2: Entering an invalid mainnet RPC URL (works, but not visible in video due to black security screen) Use this network button stays disabled
✅ Custom mainnet Scenario 3: Entering a valid mainnet RPC URL (works, but not visible in video due to black security screen)
✅ Custom mainnet Scenario 4: Editing a custom mainnet URL on the settings and privacy view
✅ Custom mainnet Scenario 5: Deleting a custom mainnet URL on the settings and privacy view
https://screenrec.com/share/dglFf6kVoX

Browser Regression
✅ Scenario: Searching an invalid url and prompts the user with an error message:
✅ Scenario: Navigation with browser controls:
✅ Scenario: ENS website loads correctly:
✅ Scenario: From the browser I can successfully upload a picture:
✅ Scenario: Address bar:
✅ Scenario: Adding browser Favorites:
https://screenrec.com/share/zdoStPN3rK
✅ Scenario: Browser Options Menu:
✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
✅ Scenario: Navigate to DappsMarketplace and connect wallet account:
https://screenrec.com/share/tADa0K4hvM

Network Regression
✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow: https://screenrec.com/share/DnNXcqzlBb
✅ Scenario: I can remove a custom network that was added via the custom network flow.
✅ Scenario Outline: Adding a network via a Dapp:
https://screenrec.com/share/SpAC14v3B9
✅ Scenario Outline: Adding a network via the new popular network flow:
✅ Scenario: Adding a network via the custom network flow:
✅ Scenario: Adding a custom network and editing the network:
✅ Scenario: Editing a popular network:
https://screenrec.com/share/FOQIg6jLx7

QR Scanner Regression
✅ QR Scanner Scenario 1: From the in-app camera, I should be able to scan a valid QR code containing an address.
✅QR Scanner Scenario 2: I should be able to use the QR scanner on the send flow to scan an address.
✅ QR Scanner Scenario 3: When I scan a dapp QR code using the in-app camera I should see the appropriate warning message.
https://screenrec.com/share/WqMDQ1fe6u
✅ QR Scanner Scenario 4: When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message.
❌ QR Scanner Scenario 5: When I scan an invalid address QR code using the in app camera I should see the appropriate warning message FAILED: the warning message does not appear!
✅ QR Scanner Scenario 6: When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message.
https://screenrec.com/share/nVt7b0eIai
✅ QR Scanner Scenario 7: A user can scan a private key QR code using the in-app camera to import an account
✅ QR Scanner Scenario 8: User scans MMM Receive QR code on different network
https://screenrec.com/share/ucOljzxXaP

Setting: General view
✅ Scenario: Changing the device language from English to Russian
https://screenrec.com/share/iF7o28gLMD
✅ Scenario: Changing the app language from English to Filipino
https://screenrec.com/share/U453fxjKBZ

@DanielTech21
Copy link
Copy Markdown

Onboarding: custom ETH mainnet
✅ Custom mainnet Scenario 1: Verifying the custom mainnet screen appears
✅ Custom mainnet Scenario 2: Entering an invalid mainnet RPC URL
✅ Custom mainnet Scenario 3: Entering a valid mainnet RPC URL
✅ Custom mainnet Scenario 4: Editing a custom mainnet URL on the settings and privacy view
✅ Custom mainnet Scenario 5: Deleting a custom mainnet URL on the settings and privacy view
https://drive.google.com/drive/folders/1HuUCAMEPilc4ychGo_b1ga9KdOgMq8Ar

Browser Regression
✅ Scenario: Searching an invalid URL and prompts the user with an error message:
✅ Scenario: Navigation with browser controls:
✅ Scenario: ENS website loads correctly:
✅ Scenario: From the browser, I can successfully upload a picture:
✅ Scenario: Address bar
✅ Scenario: Adding browser Favorites
✅ Scenario: Browser Options Menu
✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
✅ Scenario: Navigate to DappsMarketplace and connect wallet account:
https://drive.google.com/drive/folders/1QTk81MxSuWf1Wfj78PXREn-yYYt3BTps

Network Regression
✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow
✅ Scenario: I can remove a custom network added via the custom network flow.
✅ Scenario Outline: Adding a network via a Dapp
✅ Scenario Outline: Adding a network via the new popular network flow
✅ Scenario: Adding a network via the custom network flow
✅ Scenario: Adding a custom network and editing the network
✅ Scenario: Editing a popular network
https://drive.google.com/drive/folders/1Hilhg_CCf3u1HtJskb2W-xBVSfrNnf2k

QR Scanner Regression
✅ QR Scanner Scenario 1: From the in-app camera, I should be able to scan a valid QR code containing an address.
✅QR Scanner Scenario 2: I should be able to use the QR scanner on the send flow to scan an address.
✅ QR Scanner Scenario 3: When I scan a dapp QR code using the in-app camera, I should see the appropriate warning message.
✅ QR Scanner Scenario 4: When I scan a dapp QR code using the QR scanner on the send flow, I should see the appropriate error message.
❌ QR Scanner Scenario 5: When I scan an invalid address QR code using the in-app camera, I should see the appropriate warning message FAILED: the warning message does not appear!
✅ QR Scanner Scenario 6: When I scan an invalid address QR code using the QR scanner on the send flow, I should see the appropriate warning message.
✅ QR Scanner Scenario 7: A user can scan a private key QR code using the in-app camera to import an account
✅ QR Scanner Scenario 8: User scans MMM Receive QR code on a different network
https://drive.google.com/drive/folders/1CmksQxYrlP6UJER1245Mm1cyTlDF9kgm

Setting: General view
✅ Scenario: Changing the device language from English to Russian
✅ Scenario: Changing the app language from English to Filipino
https://drive.google.com/drive/folders/1cmXE0LB5ynCepPu_HIjX6E_6_7n_gbI4

This PR cherry-picks #9110

Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: CW <chris.wilcox@consensys.net>
@metamaskbot metamaskbot mentioned this pull request Apr 6, 2024
7 tasks
@seaona
Copy link
Copy Markdown
Member

seaona commented Apr 8, 2024

🟢 Confirmations UX Team QA Sign Off.

Note:

github-actions bot and others added 2 commits April 8, 2024 20:40
This PR cherry-picks #9162

Co-authored-by: Owen Craston <owen.craston@consensys.net>
## **Description**

This PR cherry picks this changes on this
[PR](#9148)

## **Related issues**

Fixes: #[9111](#9122)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding


Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling


guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@plasmacorral
Copy link
Copy Markdown
Contributor

🟢 Approval from Accounts team

2 accounts team changes are ready for release with the inclusion of cherry pick to bring in Update account name in PreferencesController AND AccountsController #9162

This PR cherry-picks #9174

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Kylan Hurt and others added 4 commits April 9, 2024 14:05
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
This PR cherry-picks #9185
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
This PR cherry-picks #9260

Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
@chrisleewilcox
Copy link
Copy Markdown
Contributor

chrisleewilcox commented Apr 12, 2024

Upgrade testing

Wallet setup
3 wallet accounts
1 imported account with NFTs
1 imported ENS account with NFTs
2 HW accounts
browser with saved bookmarks

iOS

  • 7.19.0 ==> 7.20.0 ✅
  • 7.18.0 ==> 7.20.0 ✅

android

  • 7.19.1 ==> 7.20.0 ✅
  • 7.17.0 ==> 7.20.0 ✅

@chrisleewilcox
Copy link
Copy Markdown
Contributor

@chrisleewilcox
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman requested a review from a team April 12, 2024 21:35
@sethkfman sethkfman requested a review from a team as a code owner April 12, 2024 21:35
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Merge `main` into `release/7.20.0`

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Co-authored-by: Curtis David <Curtis.David7@gmail.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Xiaoming Wang <dawnseeker8@gmail.com>
Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
Co-authored-by: Omridan159 <omridan159@gmail.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: sethkfman <seth.kaufman@consensys.net>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: salimtb <salim.toubal@outlook.com>
Co-authored-by: Owen Craston <owen.craston@consensys.net>
Co-authored-by: João Loureiro <1649425+jpcloureiro@users.noreply.github.com>
Co-authored-by: Aslau Mario-Daniel <marioaslau@gmail.com>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Amélie <amelie.chan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: CW <chris.wilcox@consensys.net>
Co-authored-by: Omri Dan <61094771+omridan159@users.noreply.github.com>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: Kylan Hurt <kylanhurt@users.noreply.github.com>
Co-authored-by: SamuelSalas <samuel.salas.reyes@gmail.com>
Co-authored-by: tommasini <tommasini15@gmail.com>
Co-authored-by: Kylan Hurt <kylan.hurt@gmail.com>
Co-authored-by: Nicholas Ellul <nicholas.ellul1@gmail.com>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Co-authored-by: Jonathan Ferreira <44679989+Jonathansoufer@users.noreply.github.com>
Co-authored-by: Mpendulo Ndlovu <mpendulo@elefantel.com>
Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Priya <priya.narayanaswamy@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 15, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a526be3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be210e67-4686-447b-9bcd-1673648960d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 99ab375
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d18c0f15-a8f2-42c8-8fe9-78fe3513080e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L
Copy link
Copy Markdown
Contributor

Cal-L commented Apr 16, 2024

E2E failure due to flaky test. Bitrise check succeeded, which runs the same failed flaky test

@Cal-L Cal-L added release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E and removed release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E labels Apr 16, 2024
@Cal-L Cal-L merged commit 060ff00 into main Apr 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels Apr 16, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.20.0) on PR and removing other release labels (release-7.22.0).

1 similar comment
@metamaskbot
Copy link
Copy Markdown
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.20.0) on PR and removing other release labels (release-7.22.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.