fix: Tokens disappearing when updating by tommasini · Pull Request #9148 · MetaMask/metamask-mobile

tommasini · 2024-04-05T12:18:50Z

Description

The variable newlySelectedInternalAccount.address, that was being returned by the AccountsController:selectedAccountChange event was on a lowercase format. We were duplicating the accounts, so one account was checksummed and another not, which was making the tokens be on storage but not showing because the new selected account was not with tokens imported.

This is a how the data storage was:

{"allDetectedTokens": {"0x1": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array]}, "0xa86a": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array], "0x2990079bcdee240329a520d2444386fc119da21a": [Array]}}, "allIgnoredTokens": {}, "allTokens": {"0xa86a": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array]}}, "detectedTokens": [{"address": "0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x9702230a8ea53601f5cd2dc00fdbc13d4df4a8c7.png", "isERC721": false, "name": "TetherToken", "symbol": "USDT"}, {"address": "0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e.png", "isERC721": false, "name": "USD Coin", "symbol": "USDC"}, {"address": "0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb31f66aa3c1e785363f0875a1b74e27b85fd66c7.png", "isERC721": false, "name": "Wrapped AVAX", "symbol": "WAVAX"}, {"address": "0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x49d5c2bdffac6ce2bfdb6640f4f80f226bc10bab.png", "isERC721": false, "name": "Wrapped Ether", "symbol": "WETH.E"}, {"address": "0x50b7545627a5162F82A992c33b87aDc75187B218", "aggregators": [Array], "decimals": 8, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x50b7545627a5162f82a992c33b87adc75187b218.png", "isERC721": false, "name": "Wrapped BTC", "symbol": "WBTC.E"}, {"address": "0x63a72806098Bd3D9520cC43356dD78afe5D386D9", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x63a72806098bd3d9520cc43356dd78afe5d386d9.png", "isERC721": false, "name": "Aave Token", "symbol": "AAVE.E"}, {"address": "0x8b82A291F83ca07Af22120ABa21632088fC92931", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x8b82a291f83ca07af22120aba21632088fc92931.png", "isERC721": false, "name": "Ethereum  Wormhole ", "symbol": "ETH"}, {"address": "0x120AD3e5A7c796349e591F1570D9f7980F4eA9cb", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x120ad3e5a7c796349e591f1570d9f7980f4ea9cb.png", "isERC721": false, "name": "Axelar Wrapped LUNA", "symbol": "LUNA"}], "ignoredTokens": [], "tokens": []}

This is how it is now:

{
   "allDetectedTokens":{
      "0x1":{
         "0x2990079bcdEe240329a520d2444386FC119da21a":[
            "Array"
         ]
      },
      "0xa86a":{
         "0x2990079bcdEe240329a520d2444386FC119da21a":[
            "Array"
         ]
      }
   },
   "allIgnoredTokens":{
      
   },
   "allTokens":{
      "0xa86a":{
         "0x2990079bcdEe240329a520d2444386FC119da21a":[
            "Array"
         ]
      }
   },
   "detectedTokens":[
      
   ],
   "ignoredTokens":[
      
   ],
   "tokens":[
      {
         "address":"0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":6,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x9702230a8ea53601f5cd2dc00fdbc13d4df4a8c7.png",
         "name":"TetherToken",
         "symbol":"USDT"
      },
      {
         "address":"0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":6,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e.png",
         "name":"USD Coin",
         "symbol":"USDC"
      },
      {
         "address":"0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":18,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb31f66aa3c1e785363f0875a1b74e27b85fd66c7.png",
         "name":"Wrapped AVAX",
         "symbol":"WAVAX"
      },
      {
         "address":"0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":18,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x49d5c2bdffac6ce2bfdb6640f4f80f226bc10bab.png",
         "name":"Wrapped Ether",
         "symbol":"WETH.E"
      },
      {
         "address":"0x50b7545627a5162F82A992c33b87aDc75187B218",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":8,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x50b7545627a5162f82a992c33b87adc75187b218.png",
         "name":"Wrapped BTC",
         "symbol":"WBTC.E"
      },
      {
         "address":"0x63a72806098Bd3D9520cC43356dD78afe5D386D9",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":18,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x63a72806098bd3d9520cc43356dd78afe5d386d9.png",
         "name":"Aave Token",
         "symbol":"AAVE.E"
      },
      {
         "address":"0x8b82A291F83ca07Af22120ABa21632088fC92931",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":18,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x8b82a291f83ca07af22120aba21632088fc92931.png",
         "name":"Ethereum  Wormhole ",
         "symbol":"ETH"
      },
      {
         "address":"0x120AD3e5A7c796349e591F1570D9f7980F4eA9cb",
         "aggregators":[
            "Array"
         ],
         "balanceError":null,
         "decimals":6,
         "image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x120ad3e5a7c796349e591f1570d9f7980f4ea9cb.png",
         "name":"Axelar Wrapped LUNA",
         "symbol":"LUNA"
      }
   ]
}

Related issues

Fixes: #9122

Manual testing steps

Go to uniswap, pancake swap, open sea
Connect with those dapps
Disconnected with those dapps
Performed a swap on uniswap on avalanche and binance smart chain

Screenshots/Recordings

Upgrade path recording:

Uploading Screen Recording 2024-04-05 at 13.14.41.mov…

Before

RPReplay_Final1712163751.MP4

After

screen-20240408-200805.mp4

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…solve the tokens issue

github-actions · 2024-04-05T12:19:11Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2024-04-05T12:30:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.99%. Comparing base (1c1c9ed) to head (311a2d0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9148   +/-   ##
=======================================
  Coverage   45.98%   45.99%           
=======================================
  Files        1273     1273           
  Lines       31342    31338    -4     
  Branches     3213     3213           
=======================================
  Hits        14414    14414           
+ Misses      16079    16075    -4     
  Partials      849      849

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-05T12:34:30Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 311a2d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e471a640-8754-4630-9f8d-cccc810011a6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston

why not remove the selectedAddress: accountsController.getSelectedAccount().address, on line 521 if we are going to stick to using the preferences controller as the source of truth?

…ller

…y preferences controller

… controller

sonarqubecloud · 2024-04-08T11:17:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-04-08T12:01:40Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 06da26f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a30877bc-52aa-4270-a5e1-1e5bf198463d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston

Code looks good to me and I did a QA pass and it also looked good.

Test paths

on version 7.19.0 QA build...
imported an account via SRP with eth
imported an account via private key with eth and tokens (orangefox.eth)
imported tokens on mainnet
added custom networks (polygon, BNB)
imported available tokens
switched networks
added a new account
updated to a QA build of this branch
all accounts were present with the correct names
all mainnet balances were correct
all mainnet tokens were present with the correct balances
all custom network balances were correct
all custom neto\work tokens and token balances were present and correct

Video

screen-20240408-200805.mp4

reverting only the tokens controller and tokens rates controller for …

812b443

…solve the tokens issue

tommasini added team-accounts-framework Accounts team team-mobile-platform Mobile Platform team release-7.20.0 Issue or pull request that will be included in release 7.20.0 labels Apr 5, 2024

fix prettier

311a2d0

tommasini added the Run Smoke E2E label Apr 5, 2024

tommasini added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Apr 5, 2024

tommasini marked this pull request as ready for review April 5, 2024 13:15

tommasini requested a review from a team as a code owner April 5, 2024 13:15

tommasini mentioned this pull request Apr 5, 2024

fix: Tokens disappearing when updating #9137

Closed

7 tasks

tommasini changed the title ~~fix: Tokens disappearing when updating (DRAFT)~~ fix: Tokens disappearing when updating Apr 5, 2024

metamaskbot added the ready-for-dev label Apr 6, 2024

owencraston reviewed Apr 7, 2024

View reviewed changes

tommasini added 3 commits April 8, 2024 11:51

selected address is the one on preferences controller on tokensContro…

56d1db7

…ller

New token rates controller default config selected address returned b…

129754b

…y preferences controller

revert changes tokens related to get selectedAddress from preferences…

06da26f

… controller

owencraston approved these changes Apr 8, 2024

View reviewed changes

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Apr 8, 2024

owencraston approved these changes Apr 8, 2024

View reviewed changes

tommasini merged commit aecffbf into main Apr 8, 2024

tommasini deleted the fix/9122-tokens-disappearing-2 branch April 8, 2024 19:34

github-actions bot locked and limited conversation to collaborators Apr 8, 2024

github-actions bot removed the ready-for-dev label Apr 8, 2024

metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Tokens disappearing when updating #9148

fix: Tokens disappearing when updating #9148
tommasini merged 5 commits intomainfrom
fix/9122-tokens-disappearing-2

tommasini commented Apr 5, 2024 •

edited by owencraston

Loading

Uh oh!

github-actions bot commented Apr 5, 2024

Uh oh!

codecov-commenter commented Apr 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 5, 2024 •

edited by metamaskbot

Loading

Uh oh!

owencraston left a comment

Uh oh!

sonarqubecloud bot commented Apr 8, 2024

Uh oh!

github-actions bot commented Apr 8, 2024 •

edited by metamaskbot

Loading

Uh oh!

owencraston left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tommasini commented Apr 5, 2024 • edited by owencraston Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 5, 2024

Uh oh!

codecov-commenter commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 5, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

owencraston left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 8, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Apr 8, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

owencraston left a comment

Choose a reason for hiding this comment

Test paths

Video

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tommasini commented Apr 5, 2024 •

edited by owencraston

Loading

codecov-commenter commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 5, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 8, 2024 •

edited by metamaskbot

Loading