fix: Revert Update controller utils to 5.0.2 #9123
Merged
Conversation
This reverts commit 6e87690.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9123 +/- ##
==========================================
- Coverage 46.05% 46.05% -0.01%
==========================================
Files 1273 1273
Lines 31274 31273 -1
Branches 3195 3195
==========================================
- Hits 14404 14403 -1
Misses 16027 16027
Partials 843 843 ☔ View full report in Codecov by Sentry. |
Contributor
|
bergeron
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e87690.
Description
Revert Update controller utils to 5.0.2
The controller util dependency of network controller v12 is on v4 and it's not getting the patch with linea sepolia code applied, which makes updating the controller utils dependent of network controller v13 update, for simplicity we will revert this PR and then merge it after network controller v13 PR is merged
Related issues
Fixes: #9111
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-04-03.at.19.11.21.mov
Sendflow & dapp transaction
Screen.Recording.2024-04-04.at.09.54.11.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist