feat: Update network controller to version 13.0.1 by tommasini · Pull Request #9065 · MetaMask/metamask-mobile

tommasini · 2024-03-26T19:31:55Z

Description

Updated network controller to version 13.0.1. Also created migration to delete networkId property from the network controller state
Added an inpageProvider property with a network id property to our internal property,
Created the reducer and the action for that property with createSlice of redux toolkit
Added dispatch to the engine event subscriber networkdStateChange to update networkId
Added dispatch to the Engine file with subscribing an event networkWillChange to update networkId to "loading"
Updated the patch of network controller
Updated test cases and initial states with new data structure with the networkId property

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/1624

Manual testing steps

QA Build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b1752b4-2490-4eee-b0f9-68a347562ccd

Go to this page...

Screenshots/Recordings

Screen.Recording.2024-03-27.at.11.26.55.mov

Latest recording with new actions (while updating migration from main with account imported on optimism)

Screen.Recording.2024-03-28.at.13.09.59.mov

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…o delete networkId property from the network controller state and added a network id property to our own internal property, created the reducer and the action for that property and added the dispatch to the engine event subscriber, update the patch of network controller, updated test cases and initial states with new data structure with the networkId property

github-actions · 2024-03-26T19:32:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-03-26T19:33:34Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/network-controller@13.0.1	environment Transitive: filesystem, network	`+29`	4.69 MB	metamaskbot

View full report↗︎

codecov-commenter · 2024-03-27T11:28:23Z

Codecov Report

Attention: Patch coverage is 76.47059% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 45.42%. Comparing base (3f17ad2) to head (01c34ae).

Files	Patch %	Lines
app/core/Engine.ts	28.57%	5 Missing ⚠️
app/components/Views/Asset/index.js	0.00%	4 Missing ⚠️
app/core/BackgroundBridge/BackgroundBridge.js	20.00%	4 Missing ⚠️
app/components/Views/TransactionsView/index.js	0.00%	2 Missing ⚠️
app/core/SDKConnect/AndroidSDK/AndroidService.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9065      +/-   ##
==========================================
+ Coverage   45.35%   45.42%   +0.07%     
==========================================
  Files        1272     1274       +2     
  Lines       31247    31300      +53     
  Branches     3189     3192       +3     
==========================================
+ Hits        14171    14218      +47     
- Misses      16234    16241       +7     
+ Partials      842      841       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-27T15:43:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e2b926e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b7c5502f-15b1-4ead-9503-ff5db8a7cf69

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

andreahaku

LGTM

package.json

yarn.lock

app/util/networks/index.js

app/core/SDKConnect/AndroidSDK/AndroidService.ts

app/core/Engine.ts

Gudahtt · 2024-03-27T18:41:55Z

Great work! Mostly looks good, I left some comments/suggestions but the only real concern is what I asked about in this comment, as it may introduce a race condition where the networkId is sometimes incorrect.

christopherferreira9 · 2024-03-27T19:03:24Z

All good for SDK

…only look for network id when the network did change

github-actions · 2024-03-27T19:56:57Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6210b09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/236b9162-7a29-4a7b-85cf-d6e5b23d50b4

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function

github-actions · 2024-03-27T21:40:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6f53c81
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9902e2bb-d417-4cab-ad64-5d91662a3976

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-05T15:41:56Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0f6b255
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac46fea1-8450-4a5a-8aa8-5ebf66f716ac

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart

Looks good to me.

tommasini · 2024-04-09T18:40:22Z

Uprade path from version 7.19.0 with networks imported

Screen.Recording.2024-04-09.at.19.32.43.mov

… fresh install the networkId would not be updated because the event network did change did not trigger

github-actions · 2024-04-09T20:27:20Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1c840b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/958c4b6e-858f-43bc-8ce7-2783d97e85d7

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This reverts commit 4c26c1e.

github-actions · 2024-04-10T00:18:00Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a1981d7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d7440ac-1e21-4ee0-81ba-9344315431f0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-04-10T00:20:24Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

christopherferreira9 · 2024-04-10T10:25:09Z

all good with the sdk now 💪

NicolasMassart

Looks good to me.

tommasini added the team-mobile-platform Mobile Platform team label Mar 26, 2024

tommasini and others added 2 commits March 27, 2024 11:14

remove unusable import

22887ba

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

e2b926e

tommasini changed the title ~~feat: Update network controller to version 13.0.1. Also created migration t…~~ feat: Update network controller to version 13.0.1 Mar 27, 2024

tommasini marked this pull request as ready for review March 27, 2024 11:58

tommasini requested a review from a team March 27, 2024 11:58

tommasini requested a review from a team as a code owner March 27, 2024 11:58

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Mar 27, 2024

omridan159 previously approved these changes Mar 27, 2024

View reviewed changes

andreahaku previously approved these changes Mar 27, 2024

View reviewed changes

Gudahtt reviewed Mar 27, 2024

View reviewed changes

Changed from subscribe network state change to network did change to …

b9ae3c4

…only look for network id when the network did change

tommasini dismissed stale reviews from andreahaku and omridan159 via b9ae3c4 March 27, 2024 19:41

added js doc and unit tests for deprecatedGetNetworkId

6210b09

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Mar 27, 2024

fix new unit test, since we are not spying the convertNetworkId funct…

6f53c81

…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Mar 27, 2024

tommasini and others added 3 commits April 5, 2024 14:54

re add comment

4a36f97

remove unnecessary ts expect error comment

60c3c48

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

0f6b255

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Apr 5, 2024

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

1db2228

NicolasMassart previously approved these changes Apr 9, 2024

View reviewed changes

tommasini added 2 commits April 9, 2024 14:41

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

8294f70

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

eb5f0c0

change subscribe of network id to network state change event since on…

6ed2efa

… fresh install the networkId would not be updated because the event network did change did not trigger

tommasini dismissed NicolasMassart’s stale review via 6ed2efa April 9, 2024 20:21

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Apr 9, 2024

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

1c840b5

tommasini added 2 commits April 10, 2024 01:02

Update gas fee controller to v^7

4c26c1e

Revert "Update gas fee controller to v^7"

a1981d7

This reverts commit 4c26c1e.

tommasini added Run Smoke E2E and removed Run Smoke E2E labels Apr 10, 2024

NicolasMassart approved these changes Apr 10, 2024

View reviewed changes

tommasini merged commit 4f830c8 into main Apr 10, 2024

tommasini deleted the feat/1629-update-network-controller-v13-0-1 branch April 10, 2024 17:08

github-actions bot locked and limited conversation to collaborators Apr 10, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024

metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 10, 2024

Uh oh!

Conversation

tommasini commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 26, 2024

Uh oh!

socket-security bot commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 27, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

andreahaku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gudahtt commented Mar 27, 2024

Uh oh!

christopherferreira9 commented Mar 27, 2024

Uh oh!

github-actions bot commented Mar 27, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Mar 27, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Apr 5, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

NicolasMassart left a comment

Choose a reason for hiding this comment

Uh oh!

tommasini commented Apr 9, 2024

Uh oh!

github-actions bot commented Apr 9, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Apr 10, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Apr 10, 2024

Quality Gate passed

Uh oh!

christopherferreira9 commented Apr 10, 2024

Uh oh!

NicolasMassart left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tommasini commented Mar 26, 2024 •

edited

Loading

socket-security bot commented Mar 26, 2024 •

edited

Loading

codecov-commenter commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Mar 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Mar 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 5, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 9, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Apr 10, 2024 •

edited by metamaskbot

Loading