Skip to content

feat: patch linea token pricing#9110

Merged
bergeron merged 1 commit intomainfrom
brian/patch-linea-pricing
Apr 2, 2024
Merged

feat: patch linea token pricing#9110
bergeron merged 1 commit intomainfrom
brian/patch-linea-pricing

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Apr 1, 2024 •
edited
Loading

Description

Patches MetaMask/core#3797 to support pricing linea erc20 tokens.

Related issues

Manual testing steps

  1. Open wallet containing linea erc20 tokens
  2. Should have fiat prices

Screenshots/Recordings

Before

Screenshot 2024-04-01 at 12 47 55 PM

After

Screenshot 2024-04-01 at 12 40 05 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested review from a team, sahar-fehri and salimtb April 1, 2024 19:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title patch: linea token pricing feat: patch linea token pricing Apr 1, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bergeron bergeron mentioned this pull request Apr 1, 2024
Merged
13 tasks
sethkfman
sethkfman approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6edcb71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b2d95056-c2e4-4353-8159-fb2246e41c36

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron bergeron merged commit b90cb4a into main Apr 2, 2024
@bergeron bergeron deleted the brian/patch-linea-pricing branch April 2, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
@metamaskbot metamaskbot added release-7.21.0 Issue or pull request that will be included in release 7.21.0 release-7.20.0 Issue or pull request that will be included in release 7.20.0 and removed release-7.21.0 Issue or pull request that will be included in release 7.21.0 labels Apr 2, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 6, 2024

Missing release label release-7.20.0 on PR. Adding release label release-7.20.0 on PR and removing other release labels(release-7.21.0), as PR was cherry-picked in branch 7.20.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@salimtb salimtb salimtb approved these changes

@sahar-fehri sahar-fehri Awaiting requested review from sahar-fehri

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergeron @metamaskbot @sethkfman @salimtb