fix: Revert controller utils update#9134
Merged
chrisleewilcox merged 1 commit intorelease/7.20.0from Apr 4, 2024
Merged
Conversation
This reverts commit 6e87690. ## **Description** Revert Update controller utils to 5.0.2 The controller util dependency of network controller v12 is on v4 and it's not getting the patch with linea sepolia code applied, which makes updating the controller utils dependent of network controller v13 update, for simplicity we will revert this [PR](#9079) and then merge it after network controller v13 [PR](#9065) is merged ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/46944231/6e3ce0e2-ad7e-444d-b496-58822da3ad8f Sendflow & dapp transaction https://github.com/MetaMask/metamask-mobile/assets/46944231/38ea2ccd-b3f1-48d5-b867-00c5d7cb0507 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
|
NicolasMassart
approved these changes
Apr 4, 2024
Contributor
NicolasMassart
left a comment
There was a problem hiding this comment.
Revert seems correct.
Don't forget to create an issue to apply this again after the controller upgrade!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 6e87690. Can access the PR here
Revert Update controller utils to 5.0.2
The controller util dependency of network controller v12 is on v4 and
it's not getting the patch with linea sepolia code applied, which makes
updating the controller utils dependent of network controller v13
update, for simplicity we will revert this
PR and then
merge it after network controller v13
PR is merged
Related issues
Fixes: #9111
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-04-03.at.19.11.21.mov
Sendflow & dapp transaction
Screen.Recording.2024-04-04.at.09.54.11.mov
Before
After
Pre-merge author checklist
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist