Skip to content

fix: 9108 Keystone QR code can't send asset transaction#9185

Merged
dawnseeker8 merged 5 commits intomainfrom
fix/9108-fix-qr-code-transaction-error
Apr 11, 2024
Merged

fix: 9108 Keystone QR code can't send asset transaction#9185
dawnseeker8 merged 5 commits intomainfrom
fix/9108-fix-qr-code-transaction-error

Conversation

@dawnseeker8
Copy link
Copy Markdown
Contributor

@dawnseeker8 dawnseeker8 commented Apr 10, 2024 •
edited
Loading

Description

This PR fix the #9108 issue,
The keystone relative library used in MM mobile is too old and didnt match the version used in keyring-controller 8.0.1. this PR will upgrade those old keystonehq libraries (try to use as new version as possible) to resolve those keystone QR relative issue.

Related issues

Fixes: #9108

Manual testing steps

Scenario: Send using HW account
GIVEN I have Sepolia Test Network selected
AND I have hardware wallet account selected
WHEN I send assets
THEN assets are successfully sent (FAIL: error shown on Confirm screen)
AND send transaction is properly shown on all transactions screen

Screenshots/Recordings

Before

Screen.Recording.2024-04-01.at.1.40.50.PM.mov

After

248_1712734345.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dawnseeker8
upgrade keystonehq library to match the version used in keyring-contr…
e9694b6 
…oller to prevent the version mismatch issue.
@dawnseeker8 dawnseeker8 added release-blocker This bug is blocking the next release needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead release-7.20.0 Issue or pull request that will be included in release 7.20.0 labels Apr 10, 2024
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner April 10, 2024 07:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 changed the title Fix 9108 Keystone QR code can't send asset transaction fix: 9108 Keystone QR code can't send asset transaction Apr 10, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 10, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@keystonehq/ur-decoder@0.12.2 environment +11 320 kB soralit

🚮 Removed packages: npm/@keystonehq/metamask-airgapped-keyring@0.3.0, npm/@keystonehq/ur-decoder@0.6.1

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e9694b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/397ea631-82ca-4b6d-9f82-b430b87e0165

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7c366df
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a0cd7cf-50ba-4bb7-91ea-5c3e5b3509e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L
Copy link
Copy Markdown
Contributor

Cal-L commented Apr 10, 2024

@dawnseeker8 Could you pull from main? Bitrise test is also failing

@chrisleewilcox
Copy link
Copy Markdown
Contributor

chrisleewilcox commented Apr 10, 2024

@dawnseeker8 will this also work for swaps on hw account? Can you confirm?

@dawnseeker8
Copy link
Copy Markdown
Contributor Author

dawnseeker8 commented Apr 11, 2024 •
edited
Loading

@dawnseeker8 Could you pull from main? Bitrise test is also failing

i have done the pull again in this PR. and all e2e tests has passed now.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2ea4511
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57fe89cd-6217-4cc6-8f0b-0da103aa3f74

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vivek-consensys vivek-consensys added the QA in Progress QA has started on the feature. label Apr 11, 2024
@vivek-consensys
Copy link
Copy Markdown
Contributor

vivek-consensys commented Apr 11, 2024

Tested on iPhone 13 using iOS 17.4.1 and Samung S21 using Android 14.
Bitrise builds:- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce555c2e-ef3c-433e-97a1-69f5e60ec4b0

RPReplay_Final1712826537.MP4

@vivek-consensys
Copy link
Copy Markdown
Contributor

vivek-consensys commented Apr 11, 2024

@chrisleewilcox confirming that the swap transaction works on hw account.

RPReplay_Final1712827138.MP4

@vivek-consensys vivek-consensys removed the QA in Progress QA has started on the feature. label Apr 11, 2024
@vivek-consensys vivek-consensys added the QA Passed QA testing has been completed and passed label Apr 11, 2024
chrisleewilcox
chrisleewilcox approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dawnseeker8 dawnseeker8 merged commit 9ac717e into main Apr 11, 2024
@dawnseeker8 dawnseeker8 deleted the fix/9108-fix-qr-code-transaction-error branch April 11, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2024
@metamaskbot metamaskbot added release-7.21.0 Issue or pull request that will be included in release 7.21.0 and removed release-7.21.0 Issue or pull request that will be included in release 7.21.0 labels Apr 11, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 11, 2024

More than one release label on PR. Keeping the lowest one (release-7.20.0) on PR and removing other release labels (release-7.21.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.20.0 Issue or pull request that will be included in release 7.20.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Not able to send assets with Keystone HW account, Transaction error shown on Confirm screen

5 participants

@dawnseeker8 @Cal-L @chrisleewilcox @vivek-consensys @metamaskbot