Skip to content

cherry-pick: fix add display warning for mumbai (#9125)#9127

Merged
chrisleewilcox merged 2 commits intorelease/7.20.0from
fix/add-deprecation-warning-for-mumbai
Apr 4, 2024
Merged

cherry-pick: fix add display warning for mumbai (#9125)#9127
chrisleewilcox merged 2 commits intorelease/7.20.0from
fix/add-deprecation-warning-for-mumbai

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

This PR cherry picks #9125

## **Description**

This PR adds a display of a deprecation warning when a user switches to
MUMBAI network

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to settings => network => add network => Custom networks
2. Fill in inputs: Name:Mumbai; RPC_URL:https://80001.rpc.thirdweb.com;
chainId: 80001; Symbol: MATIC
3. Switch to this network
4. You should be able to see a deprecation warning "This network is
deprecated"

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/MetaMask/metamask-mobile/assets/10994169/2aac6cf6-b884-4dac-8505-647ce2fabf35




### **After**


https://github.com/MetaMask/metamask-mobile/assets/10994169/1ca57d35-d415-4aa5-b6e8-383973f848cd


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sahar-fehri sahar-fehri requested a review from a team as a code owner April 3, 2024 22:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2777398
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cdf17771-c612-4463-b1cd-b735492da68e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.34%. Comparing base (a562cb3) to head (3493ec0).

Files Patch % Lines
app/components/Nav/Main/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/7.20.0    #9127      +/-   ##
==================================================
- Coverage           45.98%   45.34%   -0.65%     
==================================================
  Files                1273     1272       -1     
  Lines               31342    31250      -92     
  Branches             3213     3189      -24     
==================================================
- Hits                14414    14171     -243     
- Misses              16079    16237     +158     
+ Partials              849      842       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally blocking this from being merged into this release for now. Not sure how crucial this is.

@chrisleewilcox chrisleewilcox added the DO-NOT-MERGE Pull requests that should not be merged label Apr 4, 2024
@chrisleewilcox
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox removed the DO-NOT-MERGE Pull requests that should not be merged label Apr 4, 2024
@sethkfman sethkfman changed the title fix: add display warning for mumbai (#9125) cherry-pick: fix add display warning for mumbai (#9125) Apr 4, 2024
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added team-assets release-7.20.0 Issue or pull request that will be included in release 7.20.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead Run Smoke E2E and removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E labels Apr 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3493ec0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73bb7317-ada1-45b0-9329-138b03168717

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2024

@chrisleewilcox chrisleewilcox merged commit 6444b41 into release/7.20.0 Apr 4, 2024
@chrisleewilcox chrisleewilcox deleted the fix/add-deprecation-warning-for-mumbai branch April 4, 2024 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants