Description

There have been type errors showing up on some PRs relating to image imports; TypeScript interprets them as strings, but we have them typed as ImageSourcePropType. The mismatch is there because these image imports are modified later in the build system.

Normally this is handled by our type declarations, which declare upfront which types these imports should have. But on some PRs, it seems that TypeScript will evaluate these declarations too late, after files including image imports.

I had trouble reproducing this problem on main, but it can be seen in the PR #8828 (commit b027cfa). If you include this change on that branch, it resolves the problem.

Related issues

Resolves lint error on #8828

Manual testing steps

Patch this change onto #8828 and see that the yarn lint:tsc command succeeds

Screenshots/Recordings

N/A

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.