Conversation
…o delete networkId property from the network controller state and added a network id property to our own internal property, created the reducer and the action for that property and added the dispatch to the engine event subscriber, update the patch of network controller, updated test cases and initial states with new data structure with the networkId property
…only look for network id when the network did change
…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function
…etworkProvider that will contain our internal property regarding a network provider, updated on the migrations files, backgroundBridge and related components, the test files were updated accordingly as well. On Engine file was added a subscribe of the networkWillChange event to make sure we have the networkId property reseted if the intention of switching starts
… want to investigate any issue, this is the better approach to not polute Sentry and save it for the investigations
… to fetch network id
…ageProvider with the property networkId, updated files with the new property inpageProvider, deleting old actions and reducers files about networkProvider, addressed review on unit tests, changed initial root state and fixture builder initial state with the inpageProvider, and updated respective migrations 033 and 037 with reviews and new property, updated also engine file imports with the action of the slice of inpageprovider
… fresh install the networkId would not be updated because the event network did change did not trigger
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9183 +/- ##
==========================================
- Coverage 45.58% 45.57% -0.01%
==========================================
Files 1289 1289
Lines 31973 31951 -22
Branches 3314 3314
==========================================
- Hits 14574 14562 -12
+ Misses 16528 16518 -10
Partials 871 871 ☔ View full report in Codecov by Sentry. |
|
|
E2E is failling due to flakiness, here is a screen shot of the personal sign working: |
|
|
Description
Gas fee controller updated to version ^7
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1623
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist