Skip to content

fix: check HD keyring#9092

Merged
gantunesr merged 3 commits intomainfrom
fix/keyrings-lost
Apr 12, 2024
Merged

fix: check HD keyring#9092
gantunesr merged 3 commits intomainfrom
fix/keyrings-lost

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Mar 28, 2024

Description

This PR adds a patch solution to prevent the HD keyring being removed from the @metamask/eth-keyring-controller state.

Related issues

Partially fixes: https://github.com/MetaMask/mobile-planning/issues/1507

Manual testing steps

  1. Create/import a wallet
  2. Lock the wallet
  3. Unlock the wallet
  4. Add a private key
  5. Create a new HD account
  6. Lock the wallet
  7. Unlock the wallet
  8. Connect a hardware wallet and add accounts
  9. Lock the wallet
  10. Unlock the wallet

Screenshots/Recordings

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr changed the title fix: ... fix: check HD keyring Mar 28, 2024
@gantunesr gantunesr added the team-accounts-framework Accounts team label Mar 28, 2024
@gantunesr gantunesr marked this pull request as ready for review April 7, 2024 10:21
@gantunesr gantunesr requested a review from a team April 7, 2024 10:21
@gantunesr gantunesr self-assigned this Apr 7, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 8, 2024
Copy link
Copy Markdown
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 12, 2024
@gantunesr gantunesr merged commit 278163b into main Apr 12, 2024
@gantunesr gantunesr deleted the fix/keyrings-lost branch April 12, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@metamaskbot metamaskbot added release-7.22.0 Issue or pull request that will be included in release 7.22.0 release-7.21.0 Issue or pull request that will be included in release 7.21.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels Apr 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-7.21.0 on PR. Adding release label release-7.21.0 on PR and removing other release labels(release-7.22.0), as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-accounts-framework Accounts team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants