test: 1453 refactor modal pages batch 3#8909
Merged
SamuelSalas merged 24 commits intomainfrom Apr 25, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8909 +/- ##
=======================================
Coverage 43.26% 43.26%
=======================================
Files 1271 1271
Lines 30921 30921
Branches 3092 3092
=======================================
Hits 13379 13379
Misses 16769 16769
Partials 773 773 ☔ View full report in Codecov by Sentry. |
cortisiko
requested changes
Mar 22, 2024
Member
|
@SamuelSalas I left a follow up comment. Also there are merge conflicts on your PR. Will move it back to dev in progress |
cortisiko
reviewed
Apr 18, 2024
cortisiko
previously approved these changes
Apr 24, 2024
Contributor
Author
|
Latest bitrise test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a21ca4f5-9020-47e1-9b2b-97b49d4b5ddd |
|
cortisiko
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files inside of the modal folder, the scope was divided into a batch of 4.
Files inside the scope for this batch:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a21ca4f5-9020-47e1-9b2b-97b49d4b5ddd
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist