Skip to content

fix: Update siwe parse to v2.1.0#9247

Merged
tommasini merged 5 commits intomainfrom
fix/274-update-siwe-parser
Apr 18, 2024
Merged

fix: Update siwe parse to v2.1.0#9247
tommasini merged 5 commits intomainfrom
fix/274-update-siwe-parser

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Apr 15, 2024

Description

More info here

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Apr 15, 2024
@tommasini tommasini requested a review from a team as a code owner April 15, 2024 17:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noble/hashes@1.4.0 None 0 773 kB paulmillr
npm/@spruceid/siwe-parser@2.1.0 None 0 36.3 kB sbihel
npm/apg-js@4.2.0 filesystem 0 1.45 MB ldthomas

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 15, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@noble/hashes@1.4.0, npm/@spruceid/siwe-parser@2.1.0, npm/apg-js@4.2.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2aca4c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a355b0f-3b1e-4297-bd42-401c54dfd125

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NEllusion
NEllusion previously approved these changes Apr 15, 2024
View reviewed changes
Cal-L
Cal-L reviewed Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix dedupe and e2e test failures

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9bbdc14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/687224a7-e26f-4946-9544-5539701f9745

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NEllusion
Copy link
Copy Markdown
Contributor

NEllusion commented Apr 16, 2024

@SocketSecurity ignore npm/@spruceid/siwe-parser@2.1.0

digiwand
digiwand reviewed Apr 16, 2024
View reviewed changes
@tommasini
Copy link
Copy Markdown
Contributor Author

tommasini commented Apr 16, 2024

@SocketSecurity ignore-all
After talking with @NicholasEllul, the risks discovered by socket security are acceptable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f92b0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a0382d16-c874-4684-a5ff-1b06632f5443

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@digiwand digiwand mentioned this pull request Apr 17, 2024
Merged
Cal-L
Cal-L approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

digiwand
digiwand approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge!

I created a PR to update the apg-js npm package in the spruceid/siwe repo based on #9247 (comment). If it's merged, we could remove the library from package.json

@tommasini tommasini merged commit 6f851b1 into main Apr 18, 2024
@tommasini tommasini deleted the fix/274-update-siwe-parser branch April 18, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 18, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 18, 2024
@digiwand
Copy link
Copy Markdown
Contributor

digiwand commented Apr 24, 2024

The PR mentioned above has been merged and released to @spruceid/siwe-parser@2.1.2. We could update the siwe-parser package and remove the apg-js dependency

something I was thinking is we might even be able to revert this PR. The reason is because mobile doesn't support SIWE confirmation pages yet and I don't see any use-cases for the siwe-parser in the repo

Mobile ticket to support SIWE: https://github.com/MetaMask/MetaMask-planning/issues/1128

cc: @tommasini @NicholasEllul

@NEllusion
Copy link
Copy Markdown
Contributor

NEllusion commented Apr 26, 2024

@digiwand great callout, we are reverting the change here and are instead planning on bumping this naturally with the controller upgrades

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

+2 more reviewers

@digiwand digiwand digiwand approved these changes

@NEllusion NEllusion NEllusion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tommasini @NEllusion @digiwand @Cal-L @metamaskbot