Skip to content

fix: revert siwe and apg resolution#9412

Merged
NEllusion merged 1 commit intomainfrom
fix/revert-resolution-siwe
Apr 26, 2024
Merged

fix: revert siwe and apg resolution#9412
NEllusion merged 1 commit intomainfrom
fix/revert-resolution-siwe

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Apr 25, 2024

Description

Revert:
#9247

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added the team-mobile-platform Mobile Platform team label Apr 25, 2024
@tommasini tommasini requested a review from a team as a code owner April 25, 2024 19:03
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Apr 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@spruceid/siwe-parser@2.1.0

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6e21a2e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c8d2a65-283d-4ced-97e6-845fdc0e2f4f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@NEllusion NEllusion mentioned this pull request Apr 26, 2024
Merged
7 tasks
@NEllusion NEllusion merged commit b96f63f into main Apr 26, 2024
@NEllusion NEllusion deleted the fix/revert-resolution-siwe branch April 26, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 26, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@NEllusion NEllusion NEllusion approved these changes

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @NEllusion @digiwand @metamaskbot