Skip to content

feat: add all translations necessary to notifications feature - [5 of 10]#9257

Merged
Jonathansoufer merged 9 commits intomainfrom
feat/notifications-translations
Apr 18, 2024
Merged

feat: add all translations necessary to notifications feature - [5 of 10]#9257
Jonathansoufer merged 9 commits intomainfrom
feat/notifications-translations

Conversation

@Jonathansoufer
Copy link
Copy Markdown
Contributor

@Jonathansoufer Jonathansoufer commented Apr 16, 2024 •
edited
Loading

Description

This PR implements all translations needed for Notifications feature.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Apr 16, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner April 16, 2024 11:31
@Jonathansoufer Jonathansoufer requested a review from Cal-L April 16, 2024 11:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 16, 2024
@Jonathansoufer Jonathansoufer added team-mobile-platform Mobile Platform team team-notifications-deprecated DEPRECATED: please use "team-assets" instead and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f5fbb3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/87bdc08d-dd23-493c-8aad-1cd88c29fd39

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L reviewed Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply Run E2E Smoke label once comments are all resolved

@Jonathansoufer Jonathansoufer requested a review from Cal-L April 16, 2024 21:04
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0d67b19
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e3137626-b8c9-40d4-820f-d5549b7d0b0a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L
Copy link
Copy Markdown
Contributor

Cal-L commented Apr 18, 2024

E2E failure not related to this branch

Cal-L
Cal-L approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer Jonathansoufer merged commit 0dd332e into main Apr 18, 2024
@Jonathansoufer Jonathansoufer deleted the feat/notifications-translations branch April 18, 2024 07:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 18, 2024
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. and removed team-mobile-platform Mobile Platform team labels Apr 18, 2024
@Jonathansoufer Jonathansoufer changed the title feat: add all translations necessary to notifications feature feat: add all translations necessary to notifications feature - [5 of 8] May 8, 2024
@Jonathansoufer Jonathansoufer changed the title feat: add all translations necessary to notifications feature - [5 of 8] feat: add all translations necessary to notifications feature - [5 of 10] May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jonathansoufer @Cal-L @sethkfman @metamaskbot