Skip to content

fix: Update pods from notifications changes#9228

Merged
Jonathansoufer merged 1 commit intomainfrom
fix/update-pods-from-notifications
Apr 14, 2024
Merged

fix: Update pods from notifications changes#9228
Jonathansoufer merged 1 commit intomainfrom
fix/update-pods-from-notifications

Conversation

@Cal-L
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L commented Apr 12, 2024 •
edited
Loading

Description

This PR fixes missing pod updates from a PR with notifications changes #8701
This updates both the Xcode project file as well as Podfile.lock

cc: @Jonathansoufer

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner April 12, 2024 20:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-notifications-deprecated DEPRECATED: please use "team-assets" instead needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Apr 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2eefe9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0c6bbb2d-f880-4a27-8b8a-65ddfddaa5e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Jonathansoufer
Jonathansoufer approved these changes Apr 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on notification's end. We'll add firebase as a separated PR later this week after all the UI being merged as well as the embedded snaps. So, this Pods aren't being used as of now by notifications.

@Jonathansoufer Jonathansoufer merged commit 1d1df97 into main Apr 14, 2024
@Jonathansoufer Jonathansoufer deleted the fix/update-pods-from-notifications branch April 14, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
@github-actions github-actions bot removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 14, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Jonathansoufer Jonathansoufer Jonathansoufer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jonathansoufer Jonathansoufer

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cal-L @Jonathansoufer @metamaskbot