You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
URL not called properly for Stake button since constant name changes (broken Portfolio Stake link)
isPortfolioUrl is not imported in app/components/UI/Tokens/index.tsx (broken Portfolio home link)
NOTE: These breaking issues should have been caught by the typechecker which is currently disabled for the components folder. I'd strongly advise that this is re-implemented as these issues could have been easily been caught at the commit or CI level.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
ameliejyc
changed the title
fix: add missing import and update portfolio url name
fix: add missing isPortfolioUrl import and update portfolio url name
Apr 15, 2024
More than one release label on PR. Keeping the lowest one (release-7.21.0) on PR and removing other release labels (release-7.22.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
regression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadrelease-7.21.0Issue or pull request that will be included in release 7.21.0team-stake-deprecatedDEPRECATED: please use "team-earn" instead
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9242 and #9244
More specifically, fixes these 2 issues:
isPortfolioUrlis not imported in app/components/UI/Tokens/index.tsx (broken Portfolio home link)NOTE: These breaking issues should have been caught by the typechecker which is currently disabled for the components folder. I'd strongly advise that this is re-implemented as these issues could have been easily been caught at the commit or CI level.
Related issues
Fixes: #9242 and #9244
Manual testing steps
Screenshots/Recordings
Before
Portfolio.link.bug.mov
After
bug.fix.mov
Pre-merge author checklist
Pre-merge reviewer checklist