Skip to content

chore(ramp): upgrade sdk to 1.27.1#9304

Merged
wachunei merged 3 commits intomainfrom
chore/ramp-upgrade-sdk-1.27.1
Apr 24, 2024
Merged

chore(ramp): upgrade sdk to 1.27.1#9304
wachunei merged 3 commits intomainfrom
chore/ramp-upgrade-sdk-1.27.1

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Apr 18, 2024

Description

This PR upgrades Ramp SDK to v1.27.1

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1526

Manual testing steps

  1. Go to Ramp flows
  2. Both Buy and Sell flows must not show any regressions

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features needs-money-movement-qa Tickets that need feature QA on the ramps flows Run Smoke E2E labels Apr 18, 2024
@wachunei wachunei requested a review from a team as a code owner April 18, 2024 01:38
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/on-ramp-sdk@1.27.1 Transitive: unsafe +3 783 kB pmkowalski

🚮 Removed packages: npm/@consensys/on-ramp-sdk@1.26.8

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 68b14e5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/934c1054-0f35-4f35-92b2-b83b3b508e51

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgeweiler
georgeweiler previously approved these changes Apr 19, 2024
View reviewed changes
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 19, 2024
@bkirb
Copy link
Copy Markdown
Contributor

bkirb commented Apr 23, 2024

@wachunei LGTM for QA, I finished verifying ✅

@wachunei wachunei removed the needs-money-movement-qa Tickets that need feature QA on the ramps flows label Apr 24, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wachunei wachunei merged commit 12c103b into main Apr 24, 2024
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.27.1 branch April 24, 2024 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

Assignees

No one assigned

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-money-movement issues related to Money Movement features

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wachunei @bkirb @georgeweiler @metamaskbot