Skip to content

feat: Update Gas fee controller v10#9254

Merged
tommasini merged 3 commits intomainfrom
feat/1680-gas-fee-controller-v10
Apr 18, 2024
Merged

feat: Update Gas fee controller v10#9254
tommasini merged 3 commits intomainfrom
feat/1680-gas-fee-controller-v10

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Apr 16, 2024

Description

Added new allowed actions to the gas fee controller initialization on engine file to support getNetworkClientById and getEIP1559Compatibility actions

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini
Update Gas fee controller v10, added new allowed actions to the gas f…
9355a2b 
…ee controller initialization on engine file to support fetNetworkClientById and getEIP1559Compatibility actions
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Apr 16, 2024
@tommasini tommasini requested a review from a team as a code owner April 16, 2024 10:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9355a2b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc8b7293-8b74-4044-bdfe-d16d9138684b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33f6a21
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/150b54c7-eacb-4124-ae90-52c47d4749fd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/gas-fee-controller@10.0.1 Transitive: environment, network +22 2.1 MB metamaskbot

🚮 Removed packages: npm/@metamask/gas-fee-controller@7.0.1

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 00a3efc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f9256c4-a850-41d1-8681-9678d15e4476

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

legobeat
legobeat reviewed Apr 17, 2024
View reviewed changes
@sleepytanya
Copy link
Copy Markdown
Contributor

sleepytanya commented Apr 18, 2024

I don't see any regression bugs related to gas flows.
Tested on physical Samsung S24+, Bitrise build.

@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Apr 18, 2024
@tommasini tommasini merged commit b8f758b into main Apr 18, 2024
@tommasini tommasini deleted the feat/1680-gas-fee-controller-v10 branch April 18, 2024 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 18, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

+1 more reviewer

@legobeat legobeat legobeat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommasini @sleepytanya @Cal-L @legobeat @chrisleewilcox @metamaskbot